Bug 126477

Summary: Simplify ScrollingStateNode references to various layer types
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+, eflews.bot: commit-queue-

Simon Fraser (smfr)
Reported 2014-01-03 17:25:02 PST
Simplify ScrollingStateNode references to various layer types
Attachments
Patch (25.74 KB, patch)
2014-01-03 17:30 PST, Simon Fraser (smfr) 		thorton: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-01-03 17:30:14 PST
Created attachment 220359 [details] Patch
EFL EWS Bot
Comment 2 2014-01-03 17:35:05 PST
Comment on attachment 220359 [details] Patch Attachment 220359 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/5001153871872000
Tim Horton
Comment 3 2014-01-03 17:35:59 PST
Comment on attachment 220359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220359&action=review > Source/WebCore/page/scrolling/ScrollingStateNode.h:119 > + return true; assert_not_reached? > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:244 > + scrollingStateTree().setHasChangedProperties(true); I think I've asked this before; why doesn't setPropertyChanged do this?
Simon Fraser (smfr)
Comment 4 2014-01-03 18:01:08 PST
http://trac.webkit.org/changeset/161303
Note You need to log in before you can comment on or make changes to this bug.