Bug 126477

Summary: Simplify ScrollingStateNode references to various layer types
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+, eflews.bot: commit-queue-

Description Simon Fraser (smfr) 2014-01-03 17:25:02 PST 
Simplify ScrollingStateNode references to various layer types
Comment 1 Simon Fraser (smfr) 2014-01-03 17:30:14 PST 
Created attachment 220359 [details]
Patch
Comment 2 EFL EWS Bot 2014-01-03 17:35:05 PST 
Comment on attachment 220359 [details]
Patch

Attachment 220359 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5001153871872000
Comment 3 Tim Horton 2014-01-03 17:35:59 PST 
Comment on attachment 220359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220359&action=review

> Source/WebCore/page/scrolling/ScrollingStateNode.h:119
> +        return true;

assert_not_reached?

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:244
> +    scrollingStateTree().setHasChangedProperties(true);

I think I've asked this before; why doesn't setPropertyChanged do this?
Comment 4 Simon Fraser (smfr) 2014-01-03 18:01:08 PST 
http://trac.webkit.org/changeset/161303