Bug 126473

Summary: Simplify process suppression state calculation
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix ggaren: review+

Gavin Barraclough
Reported 2014-01-03 17:00:39 PST
Don't check the application occlusion state (this is covered by the pages already), and let the page check visually idle. Remove layers of functions.
Attachments
Fix (18.87 KB, patch)
2014-01-03 17:18 PST, Gavin Barraclough
ggaren: review+
Gavin Barraclough
Comment 1 2014-01-03 17:18:54 PST
Geoffrey Garen
Comment 2 2014-01-03 17:33:07 PST
Comment on attachment 220358 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=220358&action=review > ../OpenSource/Source/WebKit2/UIProcess/WebPageProxy.cpp:520 > + return m_viewState & ViewState::IsVisuallyIdle && m_pageGroup->preferences()->pageVisibilityBasedProcessSuppressionEnabled(); Feels like this should have parens to indicate associativity. > ../OpenSource/Source/WebKit2/UIProcess/mac/WebContextMac.mm:391 > + for (const auto& context : WebContext::allContexts()) { Why does this loop use "const auto&" while the other uses "auto*"?
Geoffrey Garen
Comment 3 2014-01-03 17:37:03 PST
Comment on attachment 220358 [details] Fix Since allContexts() is a vector of WebContext*, and since the range-based for loops do not intend to modify the contents of the vector, I think they should both just say "auto" -- neither "auto*" nor "const auto&".
Sam Weinig
Comment 4 2014-01-03 17:38:30 PST
Comment on attachment 220358 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=220358&action=review r=me as well. >> ../OpenSource/Source/WebKit2/UIProcess/mac/WebContextMac.mm:391 >> + for (const auto& context : WebContext::allContexts()) { > > Why does this loop use "const auto&" while the other uses "auto*"? This should use auto*.
Gavin Barraclough
Comment 5 2014-01-03 17:54:02 PST
Committed revision 161301.
Note You need to log in before you can comment on or make changes to this bug.