Bug 126441

Summary: [CSS Shapes] Reuse contentBoxRect(), paddingBoxRect(), borderBoxRect() functions from RenderBox?
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: betravis, bjonesbe, giles_joplin, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98664    

Description Dirk Schulze 2014-01-03 10:55:10 PST 
It seems like ShapeInfo recalculates the the values necessary to determine the content-box, padding-box or border-box. Shapes maybe should use the functions contentBoxRect(), paddingBoxRect(), borderBoxRect() from RenderBox?
Comment 1 Bem Jones-Bey 2014-02-24 14:31:47 PST 
In looking at it, I don't think there's a reasonable way to do this, because those rects are in physical coordinates, and we not only need to adjust for writing mode, we need to adjust for writing direction to determine the offset to use. Strictly speaking, we could use just the size portion of those rects and then transpose as needed, but I think that would be more confusing than not. (For examples, take a look at how ShapeInfo::logicalTopOffset and ShapeInfo::logicalLeftOffset are computed.)