Bug 126433 – webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Jeremy Huddleston Sequoia]

In file included from Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:30:
In file included from ./Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:23:
In file included from ./Source/JavaScriptCore/API/JSStringRef.h:29:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/JSValueRef.h:1:
In file included from ./Source/JavaScriptCore/API/JSValueRef.h:30:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:1:
In file included from ./Source/JavaScriptCore/API/WebKitAvailability.h:46:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:38:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:68:
/usr/include/MacTypes.h:185:9: error: reference to 'Fixed' is ambiguous
typedef Fixed *                         FixedPtr;
        ^
/usr/include/MacTypes.h:184:41: note: candidate found by name lookup is 'Fixed'
typedef SInt32                          Fixed;
                                        ^
./Source/WebCore/platform/Length.h:38:30: note: candidate found by name lookup is 'WebCore::LengthType::Fixed'
    Auto, Relative, Percent, Fixed,
                             ^
In file included from Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:30:
In file included from ./Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:23:
In file included from ./Source/JavaScriptCore/API/JSStringRef.h:29:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/JSValueRef.h:1:
In file included from ./Source/JavaScriptCore/API/JSValueRef.h:30:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:1:
In file included from ./Source/JavaScriptCore/API/WebKitAvailability.h:46:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:38:
In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:68:
/usr/include/MacTypes.h:541:16: error: reference to 'Rect' is ambiguous
typedef struct Rect                     Rect;
               ^
/usr/include/MacTypes.h:535:8: note: candidate found by name lookup is 'Rect'
struct Rect {
       ^
./Source/WebCore/css/CSSPrimitiveValue.h:41:7: note: candidate found by name lookup is 'WebCore::Rect'
class Rect;
      ^


---


I really don't see why you need AvailabilityMacros.h or CF to be included in ./Source/JavaScriptCore/API/WebKitAvailability.h ... those availability macros are for system headers.

[Philip Chimento]

Created attachment 244131 [details]
Patch

Here's a simple patch to remove CoreFoundation.h for the GTK port. It applies to the 2.4.x branch since I don't believe this is an issue on 2.6.x.

Would this be able to be reviewed for 2.4.8?

For completeness, here's the output I had for this failure:

In file included from Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:30:
In file included from ./Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:23:
In file included from ./Source/JavaScriptCore/API/JSStringRef.h:29:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/JSValueRef.h:1:
In file included from ./Source/JavaScriptCore/API/JSValueRef.h:30:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:1:
In file included from ./Source/JavaScriptCore/API/WebKitAvailability.h:31:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:38:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:68:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:552:3: error:
      reference to 'Fixed' is ambiguous
  Fixed               bottom;
  ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:184:41: note:
      candidate found by name lookup is 'Fixed'
typedef SInt32                          Fixed;
                                        ^
./Source/WebCore/platform/Length.h:38:30: note: candidate found by name lookup
      is 'WebCore::LengthType::Fixed'
    Auto, Relative, Percent, Fixed,
                             ^
In file included from Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:30:
In file included from ./Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:23:
In file included from ./Source/JavaScriptCore/API/JSStringRef.h:29:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/JSValueRef.h:1:
In file included from ./Source/JavaScriptCore/API/JSValueRef.h:30:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:1:
In file included from ./Source/JavaScriptCore/API/WebKitAvailability.h:31:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:38:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:68:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:570:9: error:
      reference to 'Style' is ambiguous
typedef Style                           StyleField;
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:568:41: note:
      candidate found by name lookup is 'Style'
typedef unsigned char                   Style;
                                        ^
./Source/WebCore/style/StyleResolveTree.h:37:11: note: candidate found by name
      lookup is 'WebCore::Style'
namespace Style {
          ^

[WebKit Commit Bot]

Attachment 244131 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philip Chimento]

Would this be able to be reviewed for 2.4.9? I'm not sure why the style bot didn't passs it since it does say "Total errors 0 in 0 files."

[Csaba Osztrogonác]

(In reply to comment #3)
> Would this be able to be reviewed for 2.4.9? I'm not sure why the style bot
> didn't passs it since it does say "Total errors 0 in 0 files."

$ Tools/Scripts/svn-apply attachment.cgi\?id=244131
Parsed 0 diffs from patch file(s).

It seems it isn't valid patch for svn-apply.

[Philip Chimento]

Created attachment 252684 [details]
Patch that fixes the problem

How about this one? Without an error message I'm not really sure why it's failing.

[WebKit Commit Bot]

Attachment 252684 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Catanzaro]

Proposed for https://trac.webkit.org/wiki/WebKitGTK/2.4.x

[Csaba Osztrogonác]

Comment on attachment 252684 [details]
Patch that fixes the problem

View in context: https://bugs.webkit.org/attachment.cgi?id=252684&action=review

> b/Source/JavaScriptCore/API/WebKitAvailability.h:31
> -#ifdef __APPLE__
> +#include <wtf/Platform.h>
> +
> +#if defined(__APPLE__) && !PLATFORM(GTK)

Including Platform.h is incorrect in an API header, you can 
simply use #if defined(__APPLE__) && !defined(BUILDING_GTK__).

Otherwise I'm not sure if it is the proper fix here.
Darin, what do you think about this strange build issue?

[Philip Chimento]

Created attachment 253175 [details]
Updated patch

I'll try another build with that suggestion, but in any case here's the updated patch.

[WebKit Commit Bot]

Attachment 253175 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 253175 [details]
Updated patch

Rejecting attachment 253175 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 253175, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ng 1 patch from 1 bug.
Processing patch 253175 from bug 126433.
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit

No diff found. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 126.
Parsed 0 diffs from patch file(s).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/271771

[Philip Chimento]

Would someone be able to commit this manually? I'm pretty sure I've prepared this patch and all previous versions in the normal way, with webkit-patch, but svn-apply seems to choke on it each time.

Thanks for the review, by the way.

[Michael Catanzaro]

Created attachment 262901 [details]
Patch

[Michael Catanzaro]

Committed r190862: <http://trac.webkit.org/changeset/190862>

[Philip Chimento]

Thanks!

[Jeremy Huddleston Sequoia]

This change causes webkit-gtk to fail to build on OS X 10.9 and earlier:

See bug #152720