Summary: | REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mrobinson | ||||||
Priority: | P2 | Keywords: | Gtk, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-01-03 06:21:13 PST
Created attachment 220299 [details]
Patch
Comment on attachment 220299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220299&action=review > Tools/Scripts/run-gtk-tests:199 > - self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.library_build_path() > + self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.build_path("Libraries") library_build_path is supposed to return the path to Libraries for the autotools build and 'lib' for the cmake build. (In reply to comment #2) > (From update of attachment 220299 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220299&action=review > > > Tools/Scripts/run-gtk-tests:199 > > - self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.library_build_path() > > + self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.build_path("Libraries") > > library_build_path is supposed to return the path to Libraries for the autotools build and 'lib' for the cmake build. It looks like library_build_path should just return build_path('Libraries', '.libs', *args) for autotools. Sorry about the breakage. (In reply to comment #2) > (From update of attachment 220299 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220299&action=review > > > Tools/Scripts/run-gtk-tests:199 > > - self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.library_build_path() > > + self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.build_path("Libraries") > > library_build_path is supposed to return the path to Libraries for the autotools build and 'lib' for the cmake build. if I change common.library_build_path() I'll break the gtk doc generation (In reply to comment #4) > if I change common.library_build_path() I'll break the gtk doc generation Can't the gtkdoc build against the real libraries, instead of the libtool wrappers? I guess it depends on what the rpath is nowadays? (In reply to comment #5) > (In reply to comment #4) > > > if I change common.library_build_path() I'll break the gtk doc generation > > Can't the gtkdoc build against the real libraries, instead of the libtool wrappers? I guess it depends on what the rpath is nowadays? real libraries are in build_dir/.libs anyway, not in build_dir/Libraries/.libs (In reply to comment #6) > real libraries are in build_dir/.libs anyway, not in build_dir/Libraries/.libs Ah, right! Sorry. I'm still waking up. I think the solution here is to make another function in common for the extra libraries (like libTestWebKitAPIInjectedBundle.la). (In reply to comment #7) > (In reply to comment #6) > > > real libraries are in build_dir/.libs anyway, not in build_dir/Libraries/.libs > > Ah, right! Sorry. I'm still waking up. I think the solution here is to make another function in common for the extra libraries (like libTestWebKitAPIInjectedBundle.la). In the cmake build all the libraries are built into 'lib,' so this function could just return library_build_path. I still don't understand what's wrong with the patch TBH. (In reply to comment #9) > I still don't understand what's wrong with the patch TBH. The Libraries directory doesn't exist for the cmake build. It builds all libraries into <build_directory>/lib. (In reply to comment #10) > (In reply to comment #9) > > I still don't understand what's wrong with the patch TBH. > > The Libraries directory doesn't exist for the cmake build. It builds all libraries into <build_directory>/lib. Ah, so the problem is that it fails when building with cmake. Created attachment 220320 [details]
Updated patch
Committed r161268: <http://trac.webkit.org/changeset/161268> |