Bug 126416

Summary:	[GTK] --enable-webkit2 fails on OS X
Product:	WebKit	Reporter:	Jeremy Huddleston Sequoia <jeremyhu>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cgarcia, gustavo, mcatanzaro, mrobinson, mrowe, ossy, zan
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	126492

Description Jeremy Huddleston Sequoia 2014-01-02 20:45:25 PST

Source/WebKit2/Shared/API/c/WKBase.h has:

#if defined(__APPLE__) && !defined(BUILDING_QT__)
#include <WebKit2/WKBaseMac.h>
#endif

so that will incorrecly try to include the non-existent WebKit2/WKBaseMac.h when building webkit-gtk on OSX.

Instead of saying "apple && !qt && !gtk && !..." perhaps you should say "apple && cocoa"

Comment 1 Zan Dobersek 2014-01-03 00:46:48 PST

The code in trunk already seems to do that this way.
http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/API/c/WKBase.h

I assume you're building a specific release version?

Comment 2 Jeremy Huddleston Sequoia 2014-01-03 07:41:02 PST

(In reply to comment #1)
> The code in trunk already seems to do that this way.
> http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/API/c/WKBase.h
> 
> I assume you're building a specific release version?

Yes, this is an issue with the current release version (2.2.3), as well as the last version to support Mountain Lion and earlier (2.0.4).

Comment 3 Jeremy Huddleston Sequoia 2014-01-03 07:45:29 PST

(In reply to comment #1)
> The code in trunk already seems to do that this way.
> http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/API/c/WKBase.h

No, it looks like it's now including it when defined(__APPLE__) now (even for QT), but it should not be included when building for GTK/X11 on OS X.

Comment 4 Michael Catanzaro 2015-05-10 14:09:20 PDT

I believe this issue is obsolete based on comments in bug #126492. If this issue is still present in 2.8.1 or 2.9.1 please leave a note so we can reopen.