Bug 126409

Summary:

CStack LLInt 32-bit should build

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

116888

Attachments:

Description	Flags
the patch	msaboff: review+

Description Filip Pizlo 2014-01-02 15:10:15 PST

And the stuff we do to make it build should at least try to be correct

Comment 1 Filip Pizlo 2014-01-02 15:11:51 PST

Created attachment 220260 [details]
the patch

Comment 2 Filip Pizlo 2014-01-02 15:25:12 PST

Landed in the branch in http://trac.webkit.org/changeset/161234

Comment 3 Michael Saboff 2014-01-02 15:25:39 PST

Comment on attachment 220260 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220260&action=review

r=me, with comments.

> Source/JavaScriptCore/ChangeLog:8
> +        

Description of what you did...

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:165
>          const extraStackSpace = 16

This line can be removed.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:177
>          const extraStackSpace = 28

This line can be removed.

Comment 4 Filip Pizlo 2014-01-02 15:50:47 PST

Landed fixes to address Michael's comments in http://trac.webkit.org/changeset/161237