Bug 126372

Summary: GraphicsLayer::client() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, hw1008.kim, kling, kondapallykalyan, luiz, noam, philn, sergio, simon.fraser, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andreas Kling
Reported 2014-01-01 20:21:55 PST
GraphicsLayer::client() is never null.
Attachments
Patch (33.31 KB, patch)
2014-01-01 20:22 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (45.10 KB, patch)
2014-05-02 19:19 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Patch (46.75 KB, patch)
2014-05-02 21:11 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-01-01 20:22:17 PST
Created attachment 220202 [details] Patch
EFL EWS Bot
Comment 2 2014-01-01 20:28:10 PST
Comment on attachment 220202 [details] Patch Attachment 220202 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/5115981164707840
EFL EWS Bot
Comment 3 2014-01-01 20:35:56 PST
Comment on attachment 220202 [details] Patch Attachment 220202 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/5471460843847680
kov's GTK+ EWS bot
Comment 4 2014-01-01 20:57:58 PST
Comment on attachment 220202 [details] Patch Attachment 220202 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/6461285986205696
Hyowon Kim
Comment 5 2014-04-16 04:55:36 PDT
Hi, Andreas. Is it ok if I upload a patch for this?
Andreas Kling
Comment 6 2014-04-24 17:01:10 PDT
(In reply to comment #5) > Hi, Andreas. Is it ok if I upload a patch for this? Hi. Of course, that would be great!
Hyowon Kim
Comment 7 2014-05-02 19:19:28 PDT
Created attachment 230730 [details] Patch
Hyowon Kim
Comment 8 2014-05-02 21:11:09 PDT
Created attachment 230737 [details] Patch
WebKit Commit Bot
Comment 9 2014-05-07 04:44:29 PDT
Comment on attachment 230737 [details] Patch Clearing flags on attachment: 230737 Committed r168423: <http://trac.webkit.org/changeset/168423>
WebKit Commit Bot
Comment 10 2014-05-07 04:44:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.