Bug 126371

Summary: [GTK] fixing .ycm_extra_conf.py file
Product: WebKit Reporter: Danilo de Paula <danilo.eu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Danilo de Paula
Reported 2014-01-01 19:20:59 PST
It's an attempt to fix three problems with the current ycm_extra_conf file. The current implementation assumes that it's a symlink, which is not true. Usually python creates a pyc file, and this is what you get in __file__. the .pyc is not a symlink, and the current implementation doesn't work if that's the case. It also assumes that the user is in the root folder. If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work. Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an exception since "flag" doesn't exists. All those things were fixed and the current implementation works with the latest YouCompleteMe plugin.
Attachments
Patch (2.80 KB, patch)
2014-01-01 19:29 PST, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Patch (3.25 KB, patch)
2014-01-01 20:26 PST, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Danilo de Paula
Comment 1 2014-01-01 19:29:34 PST
Created attachment 220201 [details] Patch
Danilo de Paula
Comment 2 2014-01-01 19:39:32 PST
Comment on attachment 220201 [details] Patch asking cq
Danilo de Paula
Comment 3 2014-01-01 20:26:34 PST
Created attachment 220203 [details] Patch
Danilo de Paula
Comment 4 2014-01-01 20:33:53 PST
Comment on attachment 220203 [details] Patch small fix to select the correct line inside the ycm-make-trace
WebKit Commit Bot
Comment 5 2014-01-02 17:16:04 PST
Comment on attachment 220203 [details] Patch Clearing flags on attachment: 220203 Committed r161243: <http://trac.webkit.org/changeset/161243>
WebKit Commit Bot
Comment 6 2014-01-02 17:16:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.