Bug 126371

Summary: [GTK] fixing .ycm_extra_conf.py file
Product: WebKit Reporter: Danilo de Paula <danilo.eu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Danilo de Paula 2014-01-01 19:20:59 PST 
It's an attempt to fix three problems with the current ycm_extra_conf file.
The current implementation assumes that it's a symlink, which is not true.

Usually python creates a pyc file, and this is what you get in __file__.
the .pyc is not a symlink, and the current implementation doesn't work
if that's the case.
 
It also assumes that the user is in the root folder.
If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
 
Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
exception since "flag" doesn't exists.

All those things were fixed and the current implementation works with the latest YouCompleteMe plugin.
Comment 1 Danilo de Paula 2014-01-01 19:29:34 PST 
Created attachment 220201 [details]
Patch
Comment 2 Danilo de Paula 2014-01-01 19:39:32 PST 
Comment on attachment 220201 [details]
Patch

asking cq
Comment 3 Danilo de Paula 2014-01-01 20:26:34 PST 
Created attachment 220203 [details]
Patch
Comment 4 Danilo de Paula 2014-01-01 20:33:53 PST 
Comment on attachment 220203 [details]
Patch

small fix to select the correct line inside the ycm-make-trace
Comment 5 WebKit Commit Bot 2014-01-02 17:16:04 PST 
Comment on attachment 220203 [details]
Patch

Clearing flags on attachment: 220203

Committed r161243: <http://trac.webkit.org/changeset/161243>
Comment 6 WebKit Commit Bot 2014-01-02 17:16:06 PST 
All reviewed patches have been landed.  Closing bug.