| Summary: | RenderScrollbar: Map of scrollbar parts should use RenderPtr. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2014-01-01 16:01:39 PST
Created attachment 220197 [details]
Patch
Attachment 220197 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderPtr.h', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbar.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/rendering/RenderScrollbar.h:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220197&action=review > Source/WebCore/rendering/RenderPtr.h:165 > +template<typename T> struct HashTraits<WebCore::RenderPtr<T>> : SimpleClassHashTraits<WebCore::RenderPtr<T>> { Might be nice to have SmartPointerHashTraits in WTF to make these copy-pastes smaller. Committed r161200: <http://trac.webkit.org/changeset/161200> |