Bug 12635

Summary:

[S60] SW-V: Browser: Bookmarks with an URL containing spaces do not work

Product:

WebKit

Reporter:

Sornalatha Rathnasamy <sornalatha.rathnasamy>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Blocker

Priority:

Version:

420+

Hardware:

S60 Emulator

OS:

S60 3rd edition

URL:

http://uljava.gjmptw.de:8080/midlets/harmonized/JSR 226 - Scalable 2D/SVGStress/JSR226Midlet.jad

Attachments:

Description	Flags
3.1 patch - escape the url	none
3.1 patch - escape the url	none
3.2 patch - escape the url	none
3.2 patch - escape the Url	zalan: review-
3.1 patch - escape Url	zalan: review-
3.2 patch - escape Url	zalan: review-
3.1 patch - Escape Url	none
3.2 patch - Escape Url	none
3.1 patch	zalan: review+
3.2 patch	zalan: review+

Description Sornalatha Rathnasamy 2007-02-06 10:42:31 PST

ID:  EMGH-6XTG9Y 

Steps to reproduce:
1) Create a new bookmark and use the URL "http://uljava.gjmptw.de:8080/midlets/harmonized/JSR 226 - Scalable 2D/SVGStress/JSR226Midlet.jad"
2) Use the Bookmark and visit the site

Actual outcome:
1) Bookmark can be created
2) Browser tries to open the page but fails with "Web: no gateway reply"

Expected outcome:
1) Bookmark can be created
2) Browser accesses the URL and the process of Java Midlet install starts.

Comment 1 Sornalatha Rathnasamy 2007-02-06 10:47:18 PST

Created attachment 12977 [details]
3.1 patch - escape the url

Comment 2 Sornalatha Rathnasamy 2007-02-06 10:47:18 PST

Created attachment 12978 [details]
3.1 patch - escape the url

Comment 3 Sornalatha Rathnasamy 2007-02-06 10:49:07 PST

Created attachment 12979 [details]
3.2 patch - escape the url

Comment 4 Sornalatha Rathnasamy 2007-02-06 10:59:14 PST

Created attachment 12980 [details]
3.2 patch - escape the Url

Comment 5 zalan 2007-02-07 06:55:52 PST

Comment on attachment 12980 [details]
3.2 patch - escape the Url

iUrl=EscapeUtils::EscapeEncodeL(aUrl, EscapeUtils::EEscapeNormal);
would just do.

Comment 6 Sornalatha Rathnasamy 2007-02-07 07:15:59 PST

Created attachment 13001 [details]
3.1 patch - escape Url

Comment 7 Sornalatha Rathnasamy 2007-02-07 07:16:54 PST

Created attachment 13002 [details]
3.2 patch - escape Url

Comment 8 zalan 2007-02-07 07:34:47 PST

Comment on attachment 13001 [details]
3.1 patch - escape Url

iUrl needs to be set to NULL before the allocation beacuse EscapeEncodeL could leave and then the CUrlRequestInfo::~CUrlRequestInfo would delete iUrl twice.

delete iUrl;
iUrl = NULL;
iUrl = EscapeUtils::EscapeEncodeL( aUrl, EscapeUtils::EEscapeNormal );

and please do not change the coding style
+void CUrlRequestInfo::SetUrlL( const TDesC& aUrl )

Comment 9 zalan 2007-02-07 07:35:19 PST

Comment on attachment 13002 [details]
3.2 patch - escape Url

see above

Comment 10 Sornalatha Rathnasamy 2007-02-07 07:41:38 PST

Created attachment 13004 [details]
3.1 patch - Escape Url

Comment 11 Sornalatha Rathnasamy 2007-02-07 07:42:27 PST

Created attachment 13005 [details]
3.2 patch - Escape Url

Comment 12 Sornalatha Rathnasamy 2007-02-07 08:02:47 PST

Created attachment 13007 [details]
3.1 patch

Comment 13 Sornalatha Rathnasamy 2007-02-07 08:03:53 PST

Created attachment 13008 [details]
3.2 patch

Comment 14 zalan 2007-02-07 08:04:52 PST

Comment on attachment 13007 [details]
3.1 patch

r=me

Comment 15 zalan 2007-02-07 08:05:42 PST

Comment on attachment 13008 [details]
3.2 patch

r=me

Comment 16 Bradley Morrison 2007-02-07 08:16:06 PST

(In reply to comment #14)
> (From update of attachment 13007 [details] [edit])
> r=me
> 

Landed on 3.1 - r19464. Keeping open till it hits trunk.

Comment 17 Bradley Morrison 2007-02-08 11:02:52 PST

landed on trunk - r19501. resolved.

Comment 18 Krishna 2007-02-09 13:39:46 PST

Verified and Closed