Bug 12635

Summary:

[S60] SW-V: Browser: Bookmarks with an URL containing spaces do not work

Product:

WebKit

Reporter:

Sornalatha Rathnasamy <sornalatha.rathnasamy>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Blocker

Priority:

Version:

420+

Hardware:

S60 Emulator

OS:

S60 3rd edition

URL:

http://uljava.gjmptw.de:8080/midlets/harmonized/JSR 226 - Scalable 2D/SVGStress/JSR226Midlet.jad

Attachments:

Description	Flags
3.1 patch - escape the url	none
3.1 patch - escape the url	none
3.2 patch - escape the url	none
3.2 patch - escape the Url	zalan: review-
3.1 patch - escape Url	zalan: review-
3.2 patch - escape Url	zalan: review-
3.1 patch - Escape Url	none
3.2 patch - Escape Url	none
3.1 patch	zalan: review+
3.2 patch	zalan: review+

Sornalatha Rathnasamy

Reported 2007-02-06 10:42:31 PST

ID: EMGH-6XTG9Y Steps to reproduce: 1) Create a new bookmark and use the URL "http://uljava.gjmptw.de:8080/midlets/harmonized/JSR 226 - Scalable 2D/SVGStress/JSR226Midlet.jad" 2) Use the Bookmark and visit the site Actual outcome: 1) Bookmark can be created 2) Browser tries to open the page but fails with "Web: no gateway reply" Expected outcome: 1) Bookmark can be created 2) Browser accesses the URL and the process of Java Midlet install starts.

Attachments
3.1 patch - escape the url (1.58 KB, patch) 2007-02-06 10:47 PST, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.1 patch - escape the url (1.58 KB, patch) 2007-02-06 10:47 PST, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.2 patch - escape the url (1.47 KB, patch) 2007-02-06 10:49 PST, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.2 patch - escape the Url (1.60 KB, patch) 2007-02-06 10:59 PST, Sornalatha Rathnasamy	zalan: review-	Details Formatted Diff Diff
3.1 patch - escape Url (1.60 KB, patch) 2007-02-07 07:15 PST, Sornalatha Rathnasamy	zalan: review-	Details Formatted Diff Diff
3.2 patch - escape Url (1.81 KB, patch) 2007-02-07 07:16 PST, Sornalatha Rathnasamy	zalan: review-	Details Formatted Diff Diff
3.1 patch - Escape Url (1.57 KB, patch) 2007-02-07 07:41 PST, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.2 patch - Escape Url (1.77 KB, patch) 2007-02-07 07:42 PST, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.1 patch (1.38 KB, patch) 2007-02-07 08:02 PST, Sornalatha Rathnasamy	zalan: review+	Details Formatted Diff Diff
3.2 patch (1.58 KB, patch) 2007-02-07 08:03 PST, Sornalatha Rathnasamy	zalan: review+	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Sornalatha Rathnasamy

Comment 1 2007-02-06 10:47:18 PST

Created attachment 12977 [details] 3.1 patch - escape the url

Sornalatha Rathnasamy

Comment 2 2007-02-06 10:47:18 PST

Created attachment 12978 [details] 3.1 patch - escape the url

Sornalatha Rathnasamy

Comment 3 2007-02-06 10:49:07 PST

Created attachment 12979 [details] 3.2 patch - escape the url

Sornalatha Rathnasamy

Comment 4 2007-02-06 10:59:14 PST

Created attachment 12980 [details] 3.2 patch - escape the Url

zalan

Comment 5 2007-02-07 06:55:52 PST

Comment on attachment 12980 [details] 3.2 patch - escape the Url iUrl=EscapeUtils::EscapeEncodeL(aUrl, EscapeUtils::EEscapeNormal); would just do.

Sornalatha Rathnasamy

Comment 6 2007-02-07 07:15:59 PST

Created attachment 13001 [details] 3.1 patch - escape Url

Sornalatha Rathnasamy

Comment 7 2007-02-07 07:16:54 PST

Created attachment 13002 [details] 3.2 patch - escape Url

zalan

Comment 8 2007-02-07 07:34:47 PST

Comment on attachment 13001 [details] 3.1 patch - escape Url iUrl needs to be set to NULL before the allocation beacuse EscapeEncodeL could leave and then the CUrlRequestInfo::~CUrlRequestInfo would delete iUrl twice. delete iUrl; iUrl = NULL; iUrl = EscapeUtils::EscapeEncodeL( aUrl, EscapeUtils::EEscapeNormal ); and please do not change the coding style +void CUrlRequestInfo::SetUrlL( const TDesC& aUrl )

zalan

Comment 9 2007-02-07 07:35:19 PST

Comment on attachment 13002 [details] 3.2 patch - escape Url see above

Sornalatha Rathnasamy

Comment 10 2007-02-07 07:41:38 PST

Created attachment 13004 [details] 3.1 patch - Escape Url

Sornalatha Rathnasamy

Comment 11 2007-02-07 07:42:27 PST

Created attachment 13005 [details] 3.2 patch - Escape Url

Sornalatha Rathnasamy

Comment 12 2007-02-07 08:02:47 PST

Created attachment 13007 [details] 3.1 patch

Sornalatha Rathnasamy

Comment 13 2007-02-07 08:03:53 PST

Created attachment 13008 [details] 3.2 patch

zalan

Comment 14 2007-02-07 08:04:52 PST

Comment on attachment 13007 [details] 3.1 patch r=me

zalan

Comment 15 2007-02-07 08:05:42 PST

Comment on attachment 13008 [details] 3.2 patch r=me

Bradley Morrison

Comment 16 2007-02-07 08:16:06 PST

(In reply to comment #14) > (From update of attachment 13007 [details] [edit]) > r=me > Landed on 3.1 - r19464. Keeping open till it hits trunk.

Bradley Morrison

Comment 17 2007-02-08 11:02:52 PST

landed on trunk - r19501. resolved.

Krishna

Comment 18 2007-02-09 13:39:46 PST

Verified and Closed

Note You need to log in before you can comment on or make changes to this bug.