Bug 126326

Summary:

[PATCH] webkit-gtk + quartz build fails on X11/xresource.h code dependencies

Product:

WebKit

Reporter:

Jeremy Huddleston Sequoia <jeremyhu>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, mcatanzaro, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://trac.macports.org/ticket/39898

Bug Depends on:

Bug Blocks:

126492

Attachments:

Description	Flags
trivial patch	none

Description Jeremy Huddleston Sequoia 2013-12-30 21:21:58 PST

Issue reported via MacPorts with patch available.  See http://trac.macports.org/ticket/39898 for further information

:info:build In file included from Source/WebCore/bridge/NP_jsobject.cpp:30:
:info:build In file included from ./Source/WebCore/bridge/NP_jsobject.h:31:
:info:build ./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: 'X11/Xresource.h' file not found
:info:build     #include <X11/Xresource.h>
:info:build              ^
:info:build In file included from Source/WebCore/bridge/npruntime.cpp:31:
:info:build ./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: 'X11/Xresource.h' file not found
:info:build     #include <X11/Xresource.h>
:info:build              ^
:info:build 1 error generated.

When gtk/Quartz is used, X11/Xresource.h is still incorrectly pulled in.

Trivial patch attached.

Comment 1 Jeremy Huddleston Sequoia 2013-12-30 21:24:40 PST

Created attachment 220145 [details]
trivial patch

Comment 2 Csaba Osztrogonác 2014-01-13 06:02:20 PST

Please add changelog and set r? if you would like to ask for review.

Comment 3 Michael Catanzaro 2015-05-10 14:02:33 PDT

I believe this issue is obsolete based on comments in bug #126492. If this issue is still present in 2.8.1 or 2.9.1 please leave a note so we can reopen.