| Summary: | Pending revision popover is slightly misplaced at build.webkit.org/dashboard | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Proskuryakov
2013-12-29 13:18:00 PST
Created attachment 220088 [details]
proposed fix
Created attachment 220089 [details]
oops, fix both branches
Comment on attachment 220089 [details] oops, fix both branches View in context: https://bugs.webkit.org/attachment.cgi?id=220089&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:97 > + var messageText = openSourceRevisionsBehind + " \uff0b " + internalRevisionsBehind + " revisions behind"; Seeing "1 + 1 revisions behind" is kind of confusing. Maybe it should just be: Math.max(openSourceRevisionsBehind, internalRevisionsBehind) + " revisions behind"; Given that it will update both internal and open source in sync. How about "1 open source and 1 internal revisions behind"? But that probably won't fit :(
> Math.max(openSourceRevisionsBehind, internalRevisionsBehind) + " revisions behind"
I think that it will be very confusing to see more revisions in the popover than how many we are "behind".
Comment on attachment 220089 [details]
oops, fix both branches
This text is not new in this patch, so marking for commit queue as is. I agree that this "+" thing is not great, just not sure how to improve it.
Or maybe we could use "/" in both places instead of "+"?
Comment on attachment 220089 [details] oops, fix both branches Rejecting attachment 220089 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 220089, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 161128 = 131710e6a5d1fe0a50752b8c532937a794cda38a r161129 = c004e36dbbce058bf7afca33af7244dd9d79aee9 r161130 = 6ca890897d48f793d792072f2175f3c6ff0f56bd Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/5975425595473920 Committed <http://trac.webkit.org/r161131>. |