Bug 126276 – Remove Node::attached()

• Component: DOM
• Status: RESOLVED FIXED

[Antti Koivisto]

Replace it with renderer() or inRenderedDocument() checks.

[Antti Koivisto]

Created attachment 220085 [details]
patch

[WebKit Commit Bot]

Attachment 220085 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/fast/table/dynamic-caption-add-before-child-expected.png', u'LayoutTests/platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/ShadowRoot.cpp', u'Source/WebCore/editing/AppendNodeCommand.cpp', u'Source/WebCore/editing/InsertNodeBeforeCommand.cpp', u'Source/WebCore/editing/RemoveNodeCommand.cpp', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilder.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/PlaceholderDocument.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/xml/XMLErrors.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', '--commit-queue']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=None)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file
    lines = self._read_lines(file_path)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines
    contents = file.read()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read
    return self.reader.read(size)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read
    newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Are attachChild/detachChild next?

[Antti Koivisto]

Yeah, and getting rid of the remaining synchronous attach/detach calls in general.

[Build Bot]

Comment on attachment 220085 [details]
patch

Attachment 220085 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5149322995826688

New failing tests:
svg/custom/use-modify-target-symbol.svg
svg/custom/resource-invalidation-crash.svg
svg/custom/object-no-size-attributes.xhtml
svg/custom/use-modify-container-in-target.svg
svg/custom/use-modify-target-container.svg

[Build Bot]

Created attachment 220087 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 220085 [details]
patch

Attachment 220085 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5750343539359744

New failing tests:
svg/custom/use-modify-target-symbol.svg
svg/custom/resource-invalidation-crash.svg
svg/custom/object-no-size-attributes.xhtml
svg/custom/use-modify-container-in-target.svg
svg/custom/use-modify-target-container.svg

[Build Bot]

Created attachment 220091 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Antti Koivisto]

https://trac.webkit.org/r161127 

(without making XML parser create renderer tree lazily. that caused problems for SVG <use>)