Bug 126264

Summary: [Win] Update obsolete packages in cygwin
Product: WebKit Reporter: Andres Gomez Garcia <agomez>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jhoneycutt, mitz, roger_fong, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andres Gomez Garcia 2013-12-27 07:32:32 PST 
apache doesn't exist any more. apache2 does.

gcc doesn't exist any more. gcc-core does.

minires doesn't exist any more, it has been integrated into the cygwin one.
Comment 1 Andres Gomez Garcia 2013-12-27 07:42:54 PST 
Created attachment 220061 [details]
Patch
Comment 2 Mario Sanchez Prada 2014-01-09 10:15:31 PST 
Comment on attachment 220061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220061&action=review

> Tools/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * CygwinDownloader/cygwin-downloader.py:
> +        * CygwinDownloader/cygwin-downloader.zip:

I think you should add some brief desription here (e.g. mentioning which packages you remove/rename)
Comment 3 Brent Fulgham 2014-01-09 13:41:44 PST 
Comment on attachment 220061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220061&action=review

This looks fine to me, but we would want to make sure we don't need anything else in gcc. I'm not sure if gcc === gcc-core, or if gcc-core is a subset of what used to be in gcc? It's probably fine.

> Tools/CygwinDownloader/cygwin-downloader.py:-47
> -required_packages = frozenset(["apache",

We don't really use apache anymore (we use lighttpd for Windows testing).  But this change seems fine.
Comment 4 Brent Fulgham 2014-01-09 13:43:10 PST 
Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.

We've locked our build machines to 2.6.8 until this is fixed.
Comment 5 Andres Gomez Garcia 2014-01-15 07:12:28 PST 
(In reply to comment #3)
> (From update of attachment 220061 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220061&action=review
> 
> This looks fine to me, but we would want to make sure we don't need anything else in gcc. I'm not sure if gcc === gcc-core, or if gcc-core is a subset of what used to be in gcc? It's probably fine.
...

Actually it seems gcc-g++ would be the appropriate replacement. I will update the patch:
ftp://www.fruitbat.org/pub/cygwin/setup-legacy.ini

... 
> > Tools/CygwinDownloader/cygwin-downloader.py:-47
> > -required_packages = frozenset(["apache",
> 
> We don't really use apache anymore (we use lighttpd for Windows testing).  But this change seems fine.
..,

Then, let's drop it completely :)
Comment 6 Andres Gomez Garcia 2014-01-15 07:13:06 PST 
(In reply to comment #0)
> minires doesn't exist any more, it has been integrated into the cygwin one.

http://cygwin.com/ml/cygwin-apps/2012-01/msg00085.html
Comment 7 Andres Gomez Garcia 2014-01-15 07:13:56 PST 
(In reply to comment #4)
> Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.

Last version in cygwin is python-2.7.3

> We've locked our build machines to 2.6.8 until this is fixed.

I will add some code to ensure that we are using that version.
Comment 8 Brent Fulgham 2014-01-15 08:56:18 PST 
(In reply to comment #7)
> (In reply to comment #4)
> > Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.
> 
> Last version in cygwin is python-2.7.3

Sorry -- I made a mistake. python-2.7.3 is the 'bad' version.
Comment 9 Andres Gomez Garcia 2014-01-15 12:30:06 PST 
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #4)
> > > Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.
> > 
> > Last version in cygwin is python-2.7.3
> 
> Sorry -- I made a mistake. python-2.7.3 is the 'bad' version.

OK! Just double checking that I was doing the proper changes :)

Thanks, I will upload a new patch ASAP.
Comment 10 Andres Gomez Garcia 2014-01-15 12:54:36 PST 
Created attachment 221297 [details]
Patch
Comment 11 Andres Gomez Garcia 2014-01-16 03:30:11 PST 
Created attachment 221358 [details]
Patch
Comment 12 Brent Fulgham 2014-01-21 11:45:32 PST 
Comment on attachment 221358 [details]
Patch

This looks good to me, but I need to use the downloader zip file before I can approve it.  This may be a few more days before I can get to it. Sorry!
Comment 13 Andres Gomez Garcia 2014-01-24 17:29:30 PST 
(In reply to comment #12)
> (From update of attachment 221358 [details])
> This looks good to me, but I need to use the downloader zip file before I can approve it.  This may be a few more days before I can get to it. Sorry!

No problem, take your time and thanks for making use of it for reviewing this patch :)
Comment 14 Brent Fulgham 2014-04-02 14:15:49 PDT 
Comment on attachment 221358 [details]
Patch

This looks good.  I think that 2.7.3-1 is now working properly (at least with ToT).
Comment 15 Andres Gomez Garcia 2014-04-04 01:15:27 PDT 
Comment on attachment 221358 [details]
Patch

Clearing flags on attachment: 221358

Committed r166776: <http://trac.webkit.org/changeset/166776>
Comment 16 Andres Gomez Garcia 2014-04-04 01:15:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 17 Brent Fulgham 2014-04-04 08:55:50 PDT 
Comment on attachment 221358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221358&action=review

> Tools/CygwinDownloader/cygwin-downloader.py:73
> +required_packages_versions = {"python": "2.6.8-2"}

Could you create another bug that adds a few more requirements:

1. curl and lib curl version 7.33.0
2. subversion 1.7.x (not 1.8)?

Thanks!