Bug 126264 – [Win] Update obsolete packages in cygwin

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Andres Gomez Garcia]

apache doesn't exist any more. apache2 does.

gcc doesn't exist any more. gcc-core does.

minires doesn't exist any more, it has been integrated into the cygwin one.

[Andres Gomez Garcia]

Created attachment 220061 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 220061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220061&action=review

> Tools/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * CygwinDownloader/cygwin-downloader.py:
> +        * CygwinDownloader/cygwin-downloader.zip:

I think you should add some brief desription here (e.g. mentioning which packages you remove/rename)

[Brent Fulgham]

Comment on attachment 220061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220061&action=review

This looks fine to me, but we would want to make sure we don't need anything else in gcc. I'm not sure if gcc === gcc-core, or if gcc-core is a subset of what used to be in gcc? It's probably fine.

> Tools/CygwinDownloader/cygwin-downloader.py:-47
> -required_packages = frozenset(["apache",

We don't really use apache anymore (we use lighttpd for Windows testing).  But this change seems fine.

[Brent Fulgham]

Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.

We've locked our build machines to 2.6.8 until this is fixed.

[Andres Gomez Garcia]

(In reply to comment #3)
> (From update of attachment 220061 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220061&action=review
> 
> This looks fine to me, but we would want to make sure we don't need anything else in gcc. I'm not sure if gcc === gcc-core, or if gcc-core is a subset of what used to be in gcc? It's probably fine.
...

Actually it seems gcc-g++ would be the appropriate replacement. I will update the patch:
ftp://www.fruitbat.org/pub/cygwin/setup-legacy.ini

... 
> > Tools/CygwinDownloader/cygwin-downloader.py:-47
> > -required_packages = frozenset(["apache",
> 
> We don't really use apache anymore (we use lighttpd for Windows testing).  But this change seems fine.
..,

Then, let's drop it completely :)

[Andres Gomez Garcia]

(In reply to comment #0)
> minires doesn't exist any more, it has been integrated into the cygwin one.

http://cygwin.com/ml/cygwin-apps/2012-01/msg00085.html

[Andres Gomez Garcia]

(In reply to comment #4)
> Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.

Last version in cygwin is python-2.7.3

> We've locked our build machines to 2.6.8 until this is fixed.

I will add some code to ensure that we are using that version.

[Brent Fulgham]

(In reply to comment #7)
> (In reply to comment #4)
> > Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.
> 
> Last version in cygwin is python-2.7.3

Sorry -- I made a mistake. python-2.7.3 is the 'bad' version.

[Andres Gomez Garcia]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #4)
> > > Note that python-2.7.5 breaks the build due to some funniness with environment variable handling.
> > 
> > Last version in cygwin is python-2.7.3
> 
> Sorry -- I made a mistake. python-2.7.3 is the 'bad' version.

OK! Just double checking that I was doing the proper changes :)

Thanks, I will upload a new patch ASAP.

[Andres Gomez Garcia]

Created attachment 221297 [details]
Patch

[Andres Gomez Garcia]

Created attachment 221358 [details]
Patch

[Brent Fulgham]

Comment on attachment 221358 [details]
Patch

This looks good to me, but I need to use the downloader zip file before I can approve it.  This may be a few more days before I can get to it. Sorry!

[Andres Gomez Garcia]

(In reply to comment #12)
> (From update of attachment 221358 [details])
> This looks good to me, but I need to use the downloader zip file before I can approve it.  This may be a few more days before I can get to it. Sorry!

No problem, take your time and thanks for making use of it for reviewing this patch :)

[Brent Fulgham]

Comment on attachment 221358 [details]
Patch

This looks good.  I think that 2.7.3-1 is now working properly (at least with ToT).

[Andres Gomez Garcia]

Comment on attachment 221358 [details]
Patch

Clearing flags on attachment: 221358

Committed r166776: <http://trac.webkit.org/changeset/166776>

[Andres Gomez Garcia]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

Comment on attachment 221358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221358&action=review

> Tools/CygwinDownloader/cygwin-downloader.py:73
> +required_packages_versions = {"python": "2.6.8-2"}

Could you create another bug that adds a few more requirements:

1. curl and lib curl version 7.33.0
2. subversion 1.7.x (not 1.8)?

Thanks!