Summary: | REGRESSION: Crash when closing the web inspector with text selected | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Matt Lilek
2007-02-05 18:44:37 PST
Created attachment 13180 [details]
Update the render tree at the beginning of RenderView::selectionRect()
Includes a change log that also explains why a test isn't included.
Comment on attachment 13180 [details]
Update the render tree at the beginning of RenderView::selectionRect()
r=me
Why updateRendering and not updateLayout or updateLayoutIgnorePendingStylesheets?
Comment on attachment 13180 [details]
Update the render tree at the beginning of RenderView::selectionRect()
The normal design here is that the code that makes changes is responsible for calling updateRendering -- that's the reason for the various updateDocumentsRendering calls. Maybe we need a better solution for cases like the one in the inspector code where it's not going through JavaScript.
(In reply to comment #3) > Why updateRendering and not updateLayout or > updateLayoutIgnorePendingStylesheets? It's the least you can do. I didn't see reason to do more at that point, but I could be wrong. (In reply to comment #4) > (From update of attachment 13180 [details] [edit]) > The normal design here is that the code that makes changes is responsible for > calling updateRendering -- that's the reason for the various > updateDocumentsRendering calls. Maybe we need a better solution for cases like > the one in the inspector code where it's not going through JavaScript. The inspector is going through JavaScript, as a matter of fact: the Obj-C method that receives the notification executes a bit of JavaScript that updates the style. I'm not sure I understand the "normal design" comment. There are several instances where the code that needs up-to-date layout information calls updateLayoutIgnorePendingStylesheets(). |