Bug 126246

Summary:

EWS status JSON should include Access-Control-Allow-Origin

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	rniwa: review+

Description Alexey Proskuryakov 2013-12-26 14:24:01 PST

Because we need to load it from build.webkit.org.

Comment 1 Alexey Proskuryakov 2013-12-26 14:25:25 PST

Created attachment 220036 [details]
proposed patch

Comment 2 WebKit Commit Bot 2013-12-26 14:26:46 PST

Attachment 220036 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QueueStatusServer/app.yaml', u'Tools/QueueStatusServer/handlers/queuestatusjson.py', '--commit-queue']" exit_code: 1
ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:76:  [QueueStatusJSON.get] Instance of 'QueueStatusJSON' has no 'response' member  [pylint/E1101] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Ryosuke Niwa 2013-12-26 15:33:48 PST

Comment on attachment 220036 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220036&action=review

> Tools/QueueStatusServer/handlers/queuestatusjson.py:76
> +        self.response.headers["Access-Control-Allow-Origin"] = "*"

Should we restrict this to webkit.org sub domains?

Comment 4 Alexey Proskuryakov 2013-12-26 18:00:13 PST

> Should we restrict this to webkit.org sub domains?

I don't see any reason to, and that would interfere with testing from staging servers (such as 127.0.0.1).

Comment 5 Alexey Proskuryakov 2014-01-02 10:50:56 PST

Committed in <http://trac.webkit.org/changeset/161098> a few days ago.