Bug 126243

Summary:

[WK2][CoordinatedGraphics] Removing duplicated scale information from WebVIew.cpp

Product:

WebKit

Reporter:

Thiago de Barros Lacerda <thiago.lacerda>

Component:

WebKit2

Assignee:

Thiago de Barros Lacerda <thiago.lacerda>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, luiz, noam, ryuan.choi, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

126022, 126254

Attachments:

Description	Flags
Patch	none

Thiago de Barros Lacerda

Reported 2013-12-26 02:08:19 PST

The scale factor of the WebView must reflect the same information present in WebPageProxy. Previously, in WebView.cpp, there was a m_contentScaleFactor member, which adds information duplication and needs to be synchronizing with pageScaleFactor in WebPageProxy. We can avoid this by just making WebView access and set WebPageProxy's pageScaleFactor directly.

Attachments
Patch (4.28 KB, patch) 2013-12-26 02:15 PST, Thiago de Barros Lacerda	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Thiago de Barros Lacerda

Comment 1 2013-12-26 02:15:22 PST

Created attachment 220029 [details] Patch

Benjamin Poulain

Comment 2 2013-12-26 04:24:24 PST

Comment on attachment 220029 [details] Patch This is great.

WebKit Commit Bot

Comment 3 2013-12-26 07:00:52 PST

Comment on attachment 220029 [details] Patch Clearing flags on attachment: 220029 Committed r161087: <http://trac.webkit.org/changeset/161087>

WebKit Commit Bot

Comment 4 2013-12-26 07:00:57 PST

All reviewed patches have been landed. Closing bug.

Ryuan Choi

Comment 5 2013-12-26 18:23:11 PST

(In reply to comment #4) > All reviewed patches have been landed. Closing bug. After this commit, we have the regression that some sites are scaling up/down infinitely while loading. ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com

Thiago de Barros Lacerda

Comment 6 2013-12-26 19:11:18 PST

(In reply to comment #5) > (In reply to comment #4) > > All reviewed patches have been landed. Closing bug. > > After this commit, we have the regression that some sites are scaling up/down infinitely while loading. > > ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com We had this problem on Nix MiniBrowser too. But it was a problem on how it was structured and was a simple fix. Maybe the same on EFL?

Ryuan Choi

Comment 7 2013-12-26 19:23:08 PST

(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > All reviewed patches have been landed. Closing bug. > > > > After this commit, we have the regression that some sites are scaling up/down infinitely while loading. > > > > ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com > > We had this problem on Nix MiniBrowser too. But it was a problem on how it was structured and was a simple fix. > Maybe the same on EFL? Not sure, can I see the patch which nix fixes?

Thiago de Barros Lacerda

Comment 8 2013-12-27 02:10:17 PST

(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > All reviewed patches have been landed. Closing bug. > > > > > > After this commit, we have the regression that some sites are scaling up/down infinitely while loading. > > > > > > ./WebKitBuild/Release/bin/MiniBrowser http://www.naver.com > > > > We had this problem on Nix MiniBrowser too. But it was a problem on how it was structured and was a simple fix. > > Maybe the same on EFL? > > Not sure, can I see the patch which nix fixes? Sorry, I'm landing it today. But seems that you already found a solution :)

Note You need to log in before you can comment on or make changes to this bug.