Summary: | [GTK] [CMake] Convenience libraries that export API should be compiled with --whole-archive on Unix | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, gustavo, gyuyoung.kim, rakuco | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 115966 | ||||||
Attachments: |
|
Description
Martin Robinson
2013-12-25 10:59:15 PST
An example of this issue for me is that after linking, $ objdump -T lib/libwebkitgtk-3.0.so | grep webkit_dom_css_value_get_type does not show any output. With this change, I see: 0000000001fdefc0 g DF .text 0000000000000090 Base webkit_dom_css_value_get_type This change may seem a bit mysterious, but I've confirmed that libtool (which isn't used in the CMake build) does this as well. Created attachment 220037 [details]
Patch
Comment on attachment 220037 [details] Patch Clearing flags on attachment: 220037 Committed r161121: <http://trac.webkit.org/changeset/161121> All reviewed patches have been landed. Closing bug. |