Bug 126225

Summary:

[GTK] Fix warnings when generating WebExtensions gobject-instrospection files

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, pnormand

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pnormand: review+, pnormand: commit-queue-

Description Carlos Garcia Campos 2013-12-25 01:41:45 PST

Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:414: Warning: WebKit2WebExtension: webkit_web_page_get_dom_document: return value: Missing (transfer) annotation
Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:68: Warning: WebKit2WebExtension: webkit_web_page_get_main_frame: return value: Missing (transfer) annotation

webkit_web_page_get_main_frame is not even documented :-P

Comment 1 Carlos Garcia Campos 2013-12-25 01:44:07 PST

Created attachment 219988 [details]
Patch

Comment 2 Philippe Normand 2013-12-25 01:47:54 PST

Comment on attachment 219988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219988&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:466
> + * Retruns the main frame of a #WebKitWebPage.

Returns

Comment 3 Carlos Garcia Campos 2013-12-25 01:53:02 PST

Committed r161064: <http://trac.webkit.org/changeset/161064>