Bug 126193

Summary: Cursor height in contenteditable div includes padding/margin bottom with display:inline-block
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, commit-queue, darin, enrica, esprehn+autocc, glenn, kondapallykalyan, megan_gardner, simon.fraser, tobyfox, wenson_hsieh, yosin, zalan
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Fixes the bug
none
Fixed the test beidson: review-

Description Ryosuke Niwa 2013-12-23 17:09:13 PST
Cursor height in contenteditable div includes padding/margin bottom with display:inline-block
Comment 1 Ryosuke Niwa 2013-12-23 17:10:37 PST
Created attachment 219945 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2013-12-23 17:11:41 PST
Created attachment 219946 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2013-12-23 17:20:51 PST
Created attachment 219948 [details]
Fixed the test
Comment 4 Ryosuke Niwa 2013-12-23 17:22:20 PST
Also see https://code.google.com/p/chromium/issues/detail?id=314223
Comment 5 Brady Eidson 2016-05-24 22:07:30 PDT
Comment on attachment 219948 [details]
Fixed the test

Assuming that patches for review since 2013 are stale, r-
Comment 6 Ahmad Saleem 2022-05-31 15:48:55 PDT
I am unable to reproduce this bug using JSFiddle below from Chrome Bug URL in Safari 15.5 on macOS 12.4:

Test Case - 1 - https://jsfiddle.net/TNfeL/1/

Test Case - 2 - https://jsfiddle.net/TNfeL/

Cursor height matches the field but in test case (2) - Chrome Canary 104 again have bottom padding. While it is completely broken in Firefox Nightly 103. For Test case (1) - all browsers are consistent.

If my testing is flawed and this bug is still present, please retest it accordingly. Otherwise, please mark this as "RESOLVED CONFIGURATION CHANGED" or "RESOLVED INVALID" as needed. Thanks!
Comment 7 Alexey Proskuryakov 2022-05-31 20:03:22 PDT
Adding some experts to review the current state.
Comment 8 zalan 2022-06-01 08:27:43 PDT
This was addressed at https://trac.webkit.org/changeset/260367/webkit
Comment 9 zalan 2022-06-01 08:28:45 PDT

*** This bug has been marked as a duplicate of bug 210622 ***
Comment 10 zalan 2022-06-01 08:29:54 PDT
(In reply to Ahmad Saleem from comment #6)
> I am unable to reproduce this bug using JSFiddle below from Chrome Bug URL
> in Safari 15.5 on macOS 12.4:
> 
> Test Case - 1 - https://jsfiddle.net/TNfeL/1/
> 
> Test Case - 2 - https://jsfiddle.net/TNfeL/
> 
> Cursor height matches the field but in test case (2) - Chrome Canary 104
> again have bottom padding. While it is completely broken in Firefox Nightly
> 103. For Test case (1) - all browsers are consistent.
> 
> If my testing is flawed and this bug is still present, please retest it
> accordingly. Otherwise, please mark this as "RESOLVED CONFIGURATION CHANGED"
> or "RESOLVED INVALID" as needed. Thanks!
Thank you for testing it!