Bug 126182

Summary: Add a JSON interface for getting EWS queue status
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, rniwa, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch rniwa: review+

Alexey Proskuryakov
Reported 2013-12-23 15:00:39 PST
To show EWS status on build.webkit.org/dashboard.
Attachments
proposed patch (7.74 KB, patch)
2013-12-23 15:09 PST, Alexey Proskuryakov 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-12-23 15:09:05 PST
Created attachment 219934 [details] proposed patch
WebKit Commit Bot
Comment 2 2013-12-23 15:11:38 PST
Attachment 219934 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QueueStatusServer/app.yaml', u'Tools/QueueStatusServer/handlers/queuestatusjson.py', u'Tools/QueueStatusServer/index.yaml', u'Tools/QueueStatusServer/main.py', '--commit-queue']" exit_code: 1 ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:36: trailing whitespace [pep8/W291] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:38: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:87: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:86: whitespace before '}' [pep8/E202] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:53: [QueueStatusJSON._rows_for_work_items] Instance of 'QueueStatusJSON' has no 'request' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:65: [QueueStatusJSON._bots] Instance of 'QueueStatusJSON' has no 'request' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:68: [QueueStatusJSON._bots] Instance of 'QueueStatusJSON' has no 'request' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:78: [QueueStatusJSON.get] Instance of 'QueueStatusJSON' has no 'error' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:81: [QueueStatusJSON.get] Instance of 'QueueStatusJSON' has no 'response' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:84: [QueueStatusJSON.get] Instance of 'QueueStatusJSON' has no 'request' member [pylint/E1101] [5] ERROR: Tools/QueueStatusServer/handlers/queuestatusjson.py:89: [QueueStatusJSON.get] Instance of 'QueueStatusJSON' has no 'response' member [pylint/E1101] [5] Total errors found: 11 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2013-12-23 16:24:46 PST
Comment on attachment 219934 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219934&action=review Looks okay. > Tools/QueueStatusServer/index.yaml:62 > + - name: bot_id Why did you replace date with bot_id here?
Alexey Proskuryakov
Comment 4 2013-12-25 01:10:52 PST
> Why did you replace date with bot_id here? This was a mistake, fixed. Committed <http://trac.webkit.org/r161062>.
Note You need to log in before you can comment on or make changes to this bug.