Bug 126154 – Add id matching to the Selector Code Generator

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

Add id matching to the Selector Code Generator

[Benjamin Poulain]

Created attachment 219903 [details]
Patch

[Antti Koivisto]

Comment on attachment 219903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219903&action=review

> Source/WebCore/cssjit/SelectorCompiler.cpp:91
>          , tagName(0)
> +        , id(0)

nullptr (both)

> Source/WebCore/cssjit/SelectorCompiler.cpp:216
>          case CSSSelector::Id:
> +            {
> +                const AtomicString& id = selector->value();

I think we usually put { after case and indent only one level.

> Source/WebCore/cssjit/SelectorCompiler.cpp:763
> +
> +    //  Generate:
> +    //     elementDataAddress = element->elementData();
> +    //     if (!elementDataAddress)
> +    //         failure!
> +    LocalRegister elementDataAddress(m_registerAllocator);
> +    m_assembler.loadPtr(Assembler::Address(elementAddressRegister, Element::elementDataMemoryOffset()), elementDataAddress);
> +    failureCases.append(m_assembler.branchTestPtr(Assembler::Zero, elementDataAddress));
> +
> +    generateElementHasId(failureCases, elementDataAddress, *fragment.id);
>  }

Would be nice if we could just write the C++ and have tooling do the rest!

[Benjamin Poulain]

Committed r161010: <http://trac.webkit.org/changeset/161010>