Bug 126141

Summary:

cStack branch doesn't run navier-stokes because closure calls aren't implemented yet

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

113621

Attachments:

Description	Flags
the patch	msaboff: review+

Description Filip Pizlo 2013-12-22 16:47:15 PST

I'll look into it.

Comment 1 Filip Pizlo 2013-12-23 10:55:41 PST

Created attachment 219918 [details]
the patch

Comment 2 Michael Saboff 2013-12-23 11:04:34 PST

Comment on attachment 219918 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219918&action=review

r=me with comments.

> Source/JavaScriptCore/jit/JITCall.cpp:147
> +    addPtr(TrustedImm32(-static_cast<ptrdiff_t>(sizeof(CallerFrameAndPC))), stackPointerRegister, regT1);
>      emitGetFromCallFrameHeader64(JSStack::Callee, regT0, regT1);

Why don't you change this to a helper uses SP and takes into account the CallerFrameAndPC bias?

> Source/JavaScriptCore/jit/JITCall.cpp:191
> +    } // SP holds newCallFrame with ArgumentCount initialized.

Change the comment to include that SP is offset by CallerFrameAndPC.

Comment 3 Filip Pizlo 2013-12-23 11:11:14 PST

(In reply to comment #2)
> (From update of attachment 219918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219918&action=review
> 
> r=me with comments.
> 
> > Source/JavaScriptCore/jit/JITCall.cpp:147
> > +    addPtr(TrustedImm32(-static_cast<ptrdiff_t>(sizeof(CallerFrameAndPC))), stackPointerRegister, regT1);
> >      emitGetFromCallFrameHeader64(JSStack::Callee, regT0, regT1);
> 
> Why don't you change this to a helper uses SP and takes into account the CallerFrameAndPC bias?

Good point, I can do this in one line already.

> 
> > Source/JavaScriptCore/jit/JITCall.cpp:191
> > +    } // SP holds newCallFrame with ArgumentCount initialized.
> 
> Change the comment to include that SP is offset by CallerFrameAndPC.

Fixed.

Comment 4 Filip Pizlo 2013-12-23 11:11:53 PST

Landed in http://trac.webkit.org/changeset/161006