Bug 126117

Summary: REGRESSION(r160909): [GTK] Tests /webkit2/WebKitWebView/default-menu and /webkit2/WebKitSettings/webkit-settings fail
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eocanha, gustavo, mrobinson, rniwa
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mrobinson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 none

Carlos Garcia Campos
Reported 2013-12-21 03:01:25 PST
In r160909 the fullscreen setting default value was changed, but the unit tests relaying on the default value were not updated accordingly.
Attachments
Patch (3.24 KB, patch)
2013-12-21 03:02 PST, Carlos Garcia Campos 		mrobinson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (473.39 KB, application/zip)
2013-12-21 06:02 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-21 03:02:58 PST
Created attachment 219844 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-21 03:04:03 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Build Bot
Comment 3 2013-12-21 06:02:20 PST
Comment on attachment 219844 [details] Patch Attachment 219844 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/45518197 New failing tests: editing/execCommand/format-block-multiple-paragraphs-in-pre.html plugins/quicktime-plugin-replacement.html
Build Bot
Comment 4 2013-12-21 06:02:23 PST
Created attachment 219848 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Carlos Garcia Campos
Comment 5 2013-12-21 06:33:41 PST
Committed r160964: <http://trac.webkit.org/changeset/160964>
Note You need to log in before you can comment on or make changes to this bug.