Bug 126113

Summary: [CSSRegions] Crash when trying to select content from invalid region
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch none

Mihnea Ovidenie
Reported 2013-12-20 23:30:55 PST
After fix for https://bugs.webkit.org/show_bug.cgi?id=120769, positionForPoint for a region attempt to use the associated named flow to perform its task. However, this should happen only when the region is valid. If the region is invalid, part of a region chain, positionForPoint should behave as usual for a block, otherwise it may run into an infinite loop, which eventually leads to a crash.
Attachments
Patch (5.42 KB, patch)
2013-12-20 23:41 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2013-12-20 23:41:54 PST
Created attachment 219840 [details] Patch
Andreas Kling
Comment 2 2013-12-22 09:45:05 PST
Comment on attachment 219840 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-12-22 10:12:18 PST
Comment on attachment 219840 [details] Patch Clearing flags on attachment: 219840 Committed r160979: <http://trac.webkit.org/changeset/160979>
WebKit Commit Bot
Comment 4 2013-12-22 10:12:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.