Bug 12611

Summary:

[S60] Crash when pcre stack overflows

Product:

WebKit

Reporter:

Pat <vincent.bradley>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Blocker

Keywords:

PlatformOnly

Priority:

Version:

420+

Hardware:

S60 Hardware

OS:

S60 3rd edition

URL:

http://www.fi.map24.com & www.enviro.fi

Attachments:

Description	Flags
Patch for pcre crash, when stack overflow	yongjun.zhang: review-
2nd Patch for crash	yongjun.zhang: review+

Pat

Reported 2007-02-05 09:43:08 PST

Browser crashes when accessing the sites: fi.map24.com and enviro.fi. The JavaScriptCore/pcre has a stack overflow that causes a crash.

Attachments
Patch for pcre crash, when stack overflow (6.93 KB, patch) 2007-02-05 10:40 PST, Pat	yongjun.zhang: review-	Details Formatted Diff Diff
2nd Patch for crash (6.02 KB, patch) 2007-02-05 11:43 PST, Pat	yongjun.zhang: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pat

Comment 1 2007-02-05 10:40:18 PST

Created attachment 12936 [details] Patch for pcre crash, when stack overflow

Pat

Comment 2 2007-02-05 10:42:46 PST

For 3.0 and 3.1 Approved TSW ID: TJPI-6XQJWP For 3.1 Approved TSW ID: ALAA-6XSF7U This fix will stop processing the pcre regexp when we reach a limit on the depth of recursion in the method match(). This will prevent us from reaching a stack overflow, but will diminish the functionality of the page, since the javascript is not parsed. This solution is for a small memory device and these two web sites with abnormally huge javascript regexp requirements. Other pages are working as designed.

Yongjun Zhang

Comment 3 2007-02-05 11:34:54 PST

Comment on attachment 12936 [details] Patch for pcre crash, when stack overflow remove debug comments.

Pat

Comment 4 2007-02-05 11:43:12 PST

Created attachment 12938 [details] 2nd Patch for crash Comments and commented out debug statements removed

Yongjun Zhang

Comment 5 2007-02-05 12:54:36 PST

Comment on attachment 12938 [details] 2nd Patch for crash r=me

Bradley Morrison

Comment 6 2007-02-06 08:51:52 PST

(In reply to comment #5) > (From update of attachment 12938 [details] [edit]) > r=me > landed - r19430. Keeping this open, should it go into trunk? If not,please close.

Bradley Morrison

Comment 7 2007-02-06 15:35:38 PST

landed on s60/trunk - r19440. resolved.

Krishna

Comment 8 2007-02-09 13:38:10 PST

Verified and Closed.

Joel Parks

Comment 9 2011-03-21 11:53:06 PDT

re-purposing InTSW keyword for use by QtWebkit team

Note You need to log in before you can comment on or make changes to this bug.