Bug 126091

Summary: Web Inspector: Remove the references to Node in InjectedScript
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, graouts, joepeck, roger_fong, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-12-20 16:02:54 PST
If InjectedScript is to be moved down to JavaScriptCore it must be scrubbed of DOM references. The last references that exist are "Node" related. They are all just wrappers around existing functions. Eliminate the wrappers, and where possible move Node <-> JSNode conversions to InspectorDOMAgent static interfaces.
Attachments
[PATCH] Proposed Fix (14.88 KB, patch)
2013-12-20 16:06 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (16.28 KB, patch)
2013-12-20 16:43 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-12-20 16:03:20 PST
<rdar://problem/15712401>
Joseph Pecoraro
Comment 2 2013-12-20 16:06:58 PST
Created attachment 219807 [details] [PATCH] Proposed Fix Yay! This is the last of a set of "in WebCore" cleanup patches. The next patch will be moving a BUNCH of files into JavaScriptCore to get RuntimeAgent working there. These recent patches will make it so when the files move there are as few as possible diffs between then files, making reviewing easier.
Joseph Pecoraro
Comment 3 2013-12-20 16:43:02 PST
Created attachment 219810 [details] [PATCH] Proposed Fix Rebaselined.
WebKit Commit Bot
Comment 4 2013-12-20 18:43:49 PST
Comment on attachment 219810 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219810 Committed r160955: <http://trac.webkit.org/changeset/160955>
WebKit Commit Bot
Comment 5 2013-12-20 18:43:51 PST
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 6 2013-12-25 21:20:34 PST
This change breaks the Windows Release build, because the compiler can't decide if the PropertyDescriptor referenced in the code refers to JSC::PropertyDescriptor, or Inspector::TypeBuilder::Runtime::PropertyDescriptor, likewise with CallFrame. You and I can figure it out (as can the Debug build), but the Release build is missing something (despite the 'using' declaration.) My laptop decided to stop booting yesterday, so I can't fix it remotely. could you please check in a fix?
Joseph Pecoraro
Comment 7 2013-12-27 09:04:51 PST
I think I got a fix in with: <http://trac.webkit.org/changeset/161091>
Note You need to log in before you can comment on or make changes to this bug.