Bug 126091

Summary: Web Inspector: Remove the references to Node in InjectedScript
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, graouts, joepeck, roger_fong, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2013-12-20 16:02:54 PST 
If InjectedScript is to be moved down to JavaScriptCore it must be scrubbed of DOM references. The last references that exist are "Node" related. They are all just wrappers around existing functions. Eliminate the wrappers, and where possible move Node <-> JSNode conversions to InspectorDOMAgent static interfaces.
Comment 1 Radar WebKit Bug Importer 2013-12-20 16:03:20 PST 
<rdar://problem/15712401>
Comment 2 Joseph Pecoraro 2013-12-20 16:06:58 PST 
Created attachment 219807 [details]
[PATCH] Proposed Fix

Yay! This is the last of a set of "in WebCore" cleanup patches. The next patch will be moving a BUNCH of files into JavaScriptCore to get RuntimeAgent working there. These recent patches will make it so when the files move there are as few as possible diffs between then files, making reviewing easier.
Comment 3 Joseph Pecoraro 2013-12-20 16:43:02 PST 
Created attachment 219810 [details]
[PATCH] Proposed Fix

Rebaselined.
Comment 4 WebKit Commit Bot 2013-12-20 18:43:49 PST 
Comment on attachment 219810 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 219810

Committed r160955: <http://trac.webkit.org/changeset/160955>
Comment 5 WebKit Commit Bot 2013-12-20 18:43:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2013-12-25 21:20:34 PST 
This change breaks the Windows Release build, because the compiler can't decide if the  PropertyDescriptor referenced in the code refers to JSC::PropertyDescriptor, or  Inspector::TypeBuilder::Runtime::PropertyDescriptor, likewise with CallFrame.

You and I can figure it out (as can the Debug build), but the Release build is missing something (despite the 'using' declaration.)

My laptop decided to stop booting yesterday, so I can't fix it remotely. could you please check in a fix?
Comment 7 Joseph Pecoraro 2013-12-27 09:04:51 PST 
I think I got a fix in with:
<http://trac.webkit.org/changeset/161091>