Bug 126051

Summary:	Determination of horizontal overflow incorrect when direction:rtl
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	ahmad.saleem792, bdakin, dino, mitz, mmaxfield, sanjoy.pal, simon.fraser, zalan
Priority:	P2	Keywords:	BlinkMergeCandidate
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Description Ryosuke Niwa 2013-12-19 21:52:48 PST

Consider merging https://chromium.googlesource.com/chromium/blink/+/a3908e1d2aec2bbb08b0d17bc15831b60a2ebf5f
if the bug exists in WebKit

Correction to layoutOverflowRect calculation in case of direction:rtl

Comment 1 Ahmad Saleem 2022-09-24 03:19:29 PDT

Change in RenderBlock.cpp -> already done:

https://github.com/WebKit/WebKit/blob/48936aafec37b3b17c182f210f46e65bf6df9ba9/Source/WebCore/rendering/RenderBlock.cpp#L788

Change in RenderBox.cpp -> It seems to be missing:

https://github.com/WebKit/WebKit/blob/cfb088fd56631a371a89d06697cfba363583d33d/Source/WebCore/rendering/RenderBox.cpp#L5261

and this as well is not changed:

https://github.com/WebKit/WebKit/blob/cfb088fd56631a371a89d06697cfba363583d33d/Source/WebCore/rendering/RenderBox.cpp#L5273

Also missing changes in RenderLayerScrollableArea.cpp:

https://github.com/WebKit/WebKit/blob/71af797599da12fa56a502b6f23501f31e289dc2/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#L1071

Comment 2 Ahmad Saleem 2022-09-24 03:22:14 PDT

Although despite the changes missing - if I take the testcase added (new) from the Blink patch and change it into JSFiddle:

https://jsfiddle.net/kj9opwhL/show

Safari 16 passes all test.