Bug 126047

Summary: Clean up DFG write barriers
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121074    
Attachments:
Description Flags
Patch fpizlo: review+

Description Mark Hahnenberg 2013-12-19 21:03:13 PST 
After more feedback on the write barriers in the baseline JIT, it's time to clean up some the DFG write barrier code.
Comment 1 Mark Hahnenberg 2013-12-19 21:12:40 PST 
Created attachment 219725 [details]
Patch
Comment 2 Filip Pizlo 2013-12-19 21:21:31 PST 
Comment on attachment 219725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219725&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:5483
> -MacroAssembler::Call SpeculativeJIT::storeToWriteBarrierBuffer(CCallHelpers& jit, GPRReg cell, GPRReg scratch1, GPRReg scratch2)
> +MacroAssembler::Call SpeculativeJIT::storeToWriteBarrierBuffer(CCallHelpers& jit, GPRReg cell, GPRReg scratch1, GPRReg scratch2, ScratchRegisterAllocator& allocator)

This method exists just for Repatch, right?

In that case, we should definitely move it out of SpeculativeJIT.
Comment 3 Mark Hahnenberg 2013-12-19 21:22:01 PST 
(In reply to comment #2)
> (From update of attachment 219725 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219725&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:5483
> > -MacroAssembler::Call SpeculativeJIT::storeToWriteBarrierBuffer(CCallHelpers& jit, GPRReg cell, GPRReg scratch1, GPRReg scratch2)
> > +MacroAssembler::Call SpeculativeJIT::storeToWriteBarrierBuffer(CCallHelpers& jit, GPRReg cell, GPRReg scratch1, GPRReg scratch2, ScratchRegisterAllocator& allocator)
> 
> This method exists just for Repatch, right?
> 
> In that case, we should definitely move it out of SpeculativeJIT.

Should it just go into Repatch itself?
Comment 4 Mark Hahnenberg 2013-12-20 12:16:42 PST 
Committed r160919: <http://trac.webkit.org/changeset/160919>
Comment 5 Mark Hahnenberg 2013-12-20 12:19:00 PST 
*** Bug 126012 has been marked as a duplicate of this bug. ***