CStack Branch: Fix call operationStackCheck to check the proper stack

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Michael Saboff]

JITOperations::operationStackCheck() always checks the JSStack.  It should check the correct stack based on the state of ENABLE(LLINT_CLOOP).

[Michael Saboff]

Created attachment 219698 [details]
Patch

[Mark Lam]

Comment on attachment 219698 [details]
Patch

r=me.  This is actually more conservative than it needs to be, it’s good enough for now until JSStack can be refactored to handle the check for both cases (coming soon).

[Michael Saboff]

Committed r160871: <http://trac.webkit.org/changeset/160871>

[Geoffrey Garen]

Comment on attachment 219698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219698&action=review

> Source/JavaScriptCore/jit/JITOperations.cpp:89
> +    if (!exec->vm().isSafeToRecurse(-codeBlock->stackPointerOffset() * sizeof(Register)))

Since you're counting registers, you should use frameRegisterCount(), instead of manually converting based on SP.

[Michael Saboff]

(In reply to comment #4)
> (From update of attachment 219698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219698&action=review
> 
> > Source/JavaScriptCore/jit/JITOperations.cpp:89
> > +    if (!exec->vm().isSafeToRecurse(-codeBlock->stackPointerOffset() * sizeof(Register)))
> 
> Since you're counting registers, you should use frameRegisterCount(), instead of manually converting based on SP.

I change it.

[Michael Saboff]

(In reply to comment #4)
> (From update of attachment 219698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219698&action=review
> 
> > Source/JavaScriptCore/jit/JITOperations.cpp:89
> > +    if (!exec->vm().isSafeToRecurse(-codeBlock->stackPointerOffset() * sizeof(Register)))
> 
> Since you're counting registers, you should use frameRegisterCount(), instead of manually converting based on SP.

Landed this update in change set r160874: <http://trac.webkit.org/changeset/160874>