Bug 126025

Summary: Storing new CopiedSpace memory into a JSObject should fire a write barrier
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, gyuyoung.kim, rego+ews, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121074    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Mark Hahnenberg 2013-12-19 15:58:15 PST
Technically this is creating a pointer between a (potentially) old generation object and a young generation chunk of memory, thus there needs to be a barrier.
Comment 1 Mark Hahnenberg 2013-12-20 19:01:25 PST
Created attachment 219830 [details]
Patch
Comment 2 Build Bot 2013-12-20 20:37:13 PST
Comment on attachment 219830 [details]
Patch

Attachment 219830 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/49728087
Comment 3 Build Bot 2013-12-20 20:47:17 PST
Comment on attachment 219830 [details]
Patch

Attachment 219830 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/45518107
Comment 4 Mark Hahnenberg 2014-01-02 13:19:27 PST
Created attachment 220245 [details]
Patch
Comment 5 WebKit Commit Bot 2014-01-02 13:21:01 PST
Attachment 220245 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/heap/CopyWriteBarrier.h', u'Source/JavaScriptCore/heap/Heap.h', u'Source/JavaScriptCore/runtime/JSArray.cpp', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/MapData.cpp', u'Source/JavaScriptCore/runtime/Structure.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/runtime/JSObject.cpp:2388:  Declaration has space between type name and * in newVectorLength * sizeof  [whitespace/declaration] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 EFL EWS Bot 2014-01-02 13:23:59 PST
Comment on attachment 220245 [details]
Patch

Attachment 220245 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5114447056076800
Comment 7 Mark Hahnenberg 2014-01-02 13:31:37 PST
Created attachment 220247 [details]
Patch
Comment 8 WebKit Commit Bot 2014-01-02 13:32:41 PST
Attachment 220247 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/heap/CopyWriteBarrier.h', u'Source/JavaScriptCore/runtime/JSArray.cpp', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/MapData.cpp', u'Source/JavaScriptCore/runtime/Structure.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/runtime/JSObject.cpp:2388:  Declaration has space between type name and * in newVectorLength * sizeof  [whitespace/declaration] [3]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Mark Hahnenberg 2014-01-02 13:45:55 PST
Created attachment 220248 [details]
Patch
Comment 10 WebKit Commit Bot 2014-01-02 13:47:29 PST
Attachment 220248 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/heap/CopyWriteBarrier.h', u'Source/JavaScriptCore/runtime/JSArray.cpp', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/MapData.cpp', u'Source/JavaScriptCore/runtime/Structure.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/runtime/JSObject.cpp:2388:  Declaration has space between type name and * in newVectorLength * sizeof  [whitespace/declaration] [3]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Filip Pizlo 2014-01-02 14:18:54 PST
Comment on attachment 220248 [details]
Patch

r=me.
Comment 12 WebKit Commit Bot 2014-01-02 14:53:29 PST
Comment on attachment 220248 [details]
Patch

Clearing flags on attachment: 220248

Committed r161230: <http://trac.webkit.org/changeset/161230>
Comment 13 WebKit Commit Bot 2014-01-02 14:53:31 PST
All reviewed patches have been landed.  Closing bug.