Summary: | Have webkitdirs not look at VSINSTALLDIR variable when getting visualStudioInstallDir | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, bfulgham, commit-queue, david.delaune, roger_fong | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Bug Depends on: | 126395 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Roger Fong
2013-12-19 10:57:42 PST
Created attachment 219660 [details]
patch
Seriously? Your *fix* is to hard-code the path to Visual Studio? (In reply to comment #3) > Seriously? > > Your *fix* is to hard-code the path to Visual Studio? Can you provide an error message or other useful feedback about this change? It's not clear from your message if this prevented you from building, or simply offended your sensibilities. David filed bug 126317 about this. Hi, Any Windows developer should be able to immediately recognize the bug. The environment variables %PROGRAMFILES(X86)% and %PROGRAMFILES% are always set to the same drive as the OS. Take a quick guess as to what is happening when the build script does not locate the compiler. (In reply to comment #6) > Hi, > > Any Windows developer should be able to immediately recognize the bug. The environment variables %PROGRAMFILES(X86)% and %PROGRAMFILES% are always set to the same drive as the OS. > > Take a quick guess as to what is happening when the build script does not locate the compiler. Let's continue discussion about this problem on Bug 126317. Re-opened since this is blocked by bug 126395 |