Bug 125998

Summary: Have webkitdirs not look at VSINSTALLDIR variable when getting visualStudioInstallDir
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, david.delaune, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 126395    
Bug Blocks:    
Attachments:
Description Flags
patch ap: review+

Roger Fong
Reported 2013-12-19 10:57:42 PST
Get rid of the check for VSINSTALLDIR when building on Windows. We can't build on anything besides VS2013 anymore anyways.
Attachments
patch (1.36 KB, patch)
2013-12-19 11:00 PST, Roger Fong 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-12-19 11:00:38 PST
Created attachment 219660 [details] patch
Roger Fong
Comment 2 2013-12-19 11:07:43 PST
http://trac.webkit.org/changeset/160846
David Delaune
Comment 3 2013-12-30 17:22:51 PST
Seriously? Your *fix* is to hard-code the path to Visual Studio?
Brent Fulgham
Comment 4 2013-12-30 18:22:13 PST
(In reply to comment #3) > Seriously? > > Your *fix* is to hard-code the path to Visual Studio? Can you provide an error message or other useful feedback about this change? It's not clear from your message if this prevented you from building, or simply offended your sensibilities.
Alexey Proskuryakov
Comment 5 2013-12-30 22:26:59 PST
David filed bug 126317 about this.
David Delaune
Comment 6 2013-12-30 22:28:14 PST
Hi, Any Windows developer should be able to immediately recognize the bug. The environment variables %PROGRAMFILES(X86)% and %PROGRAMFILES% are always set to the same drive as the OS. Take a quick guess as to what is happening when the build script does not locate the compiler.
Brent Fulgham
Comment 7 2014-01-02 08:42:06 PST
(In reply to comment #6) > Hi, > > Any Windows developer should be able to immediately recognize the bug. The environment variables %PROGRAMFILES(X86)% and %PROGRAMFILES% are always set to the same drive as the OS. > > Take a quick guess as to what is happening when the build script does not locate the compiler. Let's continue discussion about this problem on Bug 126317.
WebKit Commit Bot
Comment 8 2014-01-02 11:56:01 PST
Re-opened since this is blocked by bug 126395
Note You need to log in before you can comment on or make changes to this bug.