Bug 125954

Summary: [MSE][Mac] Add AVSampleBufferRendererSynchronizer support.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2013-12-18 14:56:03 PST
[MSE][Mac] Add AVSampleBufferRendererSynchronizer support.
Attachments
Patch (16.62 KB, patch)
2013-12-18 15:00 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (16.61 KB, patch)
2013-12-18 17:21 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.61 KB, patch)
2013-12-18 17:59 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.42 KB, patch)
2013-12-18 20:20 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.58 KB, patch)
2013-12-18 21:18 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-12-18 15:00:19 PST
Created attachment 219575 [details] Patch
Eric Carlson
Comment 2 2013-12-18 15:19:29 PST
Comment on attachment 219575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219575&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:279 > + return ![m_synchronizer rate]; Why not use m_playing?
Jer Noble
Comment 3 2013-12-18 17:18:09 PST
(In reply to comment #2) > (From update of attachment 219575 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219575&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:279 > > + return ![m_synchronizer rate]; > > Why not use m_playing? Good point!
Jer Noble
Comment 4 2013-12-18 17:21:54 PST
Created attachment 219593 [details] Patch for landing
Build Bot
Comment 5 2013-12-18 17:59:29 PST
Comment on attachment 219593 [details] Patch for landing Attachment 219593 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46878151
Jer Noble
Comment 6 2013-12-18 17:59:54 PST
Created attachment 219597 [details] Patch for landing Fixed missing semicolon.
Build Bot
Comment 7 2013-12-18 18:04:27 PST
Comment on attachment 219597 [details] Patch for landing Attachment 219597 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47508153
Build Bot
Comment 8 2013-12-18 18:54:06 PST
Comment on attachment 219597 [details] Patch for landing Attachment 219597 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/44318550
Jer Noble
Comment 9 2013-12-18 20:20:34 PST
Created attachment 219608 [details] Patch for landing Removed the LOG statement which was causing problems in release builds.
Build Bot
Comment 10 2013-12-18 20:58:36 PST
Comment on attachment 219608 [details] Patch for landing Attachment 219608 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/50088499
Jer Noble
Comment 11 2013-12-18 21:18:25 PST
Created attachment 219612 [details] Patch for landing Add SOFT_LINK macros to new CoreMedia methods.
Jer Noble
Comment 12 2013-12-18 22:59:07 PST
Committed r160825: <http://trac.webkit.org/changeset/160825>
Note You need to log in before you can comment on or make changes to this bug.