Bug 125954

Summary: [MSE][Mac] Add AVSampleBufferRendererSynchronizer support.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Jer Noble 2013-12-18 14:56:03 PST 
[MSE][Mac] Add AVSampleBufferRendererSynchronizer support.
Comment 1 Jer Noble 2013-12-18 15:00:19 PST 
Created attachment 219575 [details]
Patch
Comment 2 Eric Carlson 2013-12-18 15:19:29 PST 
Comment on attachment 219575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219575&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:279
> +    return ![m_synchronizer rate];

Why not use m_playing?
Comment 3 Jer Noble 2013-12-18 17:18:09 PST 
(In reply to comment #2)
> (From update of attachment 219575 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219575&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:279
> > +    return ![m_synchronizer rate];
> 
> Why not use m_playing?

Good point!
Comment 4 Jer Noble 2013-12-18 17:21:54 PST 
Created attachment 219593 [details]
Patch for landing
Comment 5 Build Bot 2013-12-18 17:59:29 PST 
Comment on attachment 219593 [details]
Patch for landing

Attachment 219593 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/46878151
Comment 6 Jer Noble 2013-12-18 17:59:54 PST 
Created attachment 219597 [details]
Patch for landing

Fixed missing semicolon.
Comment 7 Build Bot 2013-12-18 18:04:27 PST 
Comment on attachment 219597 [details]
Patch for landing

Attachment 219597 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47508153
Comment 8 Build Bot 2013-12-18 18:54:06 PST 
Comment on attachment 219597 [details]
Patch for landing

Attachment 219597 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/44318550
Comment 9 Jer Noble 2013-12-18 20:20:34 PST 
Created attachment 219608 [details]
Patch for landing

Removed the LOG statement which was causing problems in release builds.
Comment 10 Build Bot 2013-12-18 20:58:36 PST 
Comment on attachment 219608 [details]
Patch for landing

Attachment 219608 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/50088499
Comment 11 Jer Noble 2013-12-18 21:18:25 PST 
Created attachment 219612 [details]
Patch for landing

Add SOFT_LINK macros to new CoreMedia methods.
Comment 12 Jer Noble 2013-12-18 22:59:07 PST 
Committed r160825: <http://trac.webkit.org/changeset/160825>