Summary: | PAC file: malloc deadlock sometimes causes a hang @ www.apple.com/pro/profiles/ (12586) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P1 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Maciej Stachowiak
2007-02-04 11:00:00 PST
Created attachment 13509 [details]
patch
fastMallocLock / fastMallocUnlock could maybe use better names, like fastMallocAllowed / fastMallocForbidden or somethig - there's no actual locking going on. +public: + bool m_inSubtreeMark : 1; + It might be worth adding a comment that now no more flags can be added to Node now without increasing the size of all DOM nodes on 32-bit systems. (There would be 16 in the bitfield plus the short above). I also wonder if some of the current flags can be removed to give us breathing room again. r=me Comment on attachment 13509 [details]
patch
r=me
Added a comment to Node.h. Changed names to "fastMallocForbid" and "fastMallocAllow." Committed revision 20019. |