| Summary: | [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Krzysztof Czech <k.czech> | ||||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, gyuyoung.kim, jcraig, jdiggs, mario, rakuco, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Krzysztof Czech
2013-12-17 05:04:12 PST
Created attachment 219412 [details]
patch
Comment on attachment 219412 [details] patch Thanks for the patch Krzysztof. Could you check if this patch of yours also fixes the issue reported in bug 123889 (see description and the event listener provided by Joanie there) and, if so, resolve one bug as a duplicate of the other? Also, I think you'd better place the HTML and expected files for this one in LayoutTests/accessibility and add it to the TestExpectations file for the mac (with a comment saying that isIndeterminate() is not implemented there), so we avoid that much duplication. Thanks! Comment on attachment 219412 [details]
patch
r- for Mario's comments (want to keep the review queue clear)
(In reply to comment #2) > (From update of attachment 219412 [details]) > Thanks for the patch Krzysztof. Could you check if this patch of yours also fixes the issue reported in bug 123889 (see description and the event listener provided by Joanie there) and, if so, resolve one bug as a duplicate of the other? > > Also, I think you'd better place the HTML and expected files for this one in LayoutTests/accessibility and add it to the TestExpectations file for the mac (with a comment saying that isIndeterminate() is not implemented there), so we avoid that much duplication. > > Thanks! I checked the issue reported in bug 123889. WebKitGtk MiniBrowser including my patch produces the fallowing results [check box | All condiments] has indeterminate state: True [check box | Lettuce] has indeterminate state: False The only difference from the expected result is that, it doesn't show two messages: [check box | All condiments] indeterminate state changed to: False [check box | All condiments] indeterminate state changed to: True Those should be produced while changing state of "Lettuce" checkbox. Events are not propagated properly ? (In reply to comment #4) > [...] > I checked the issue reported in bug 123889. > WebKitGtk MiniBrowser including my patch produces the fallowing results > > [check box | All condiments] has indeterminate state: True > [check box | Lettuce] has indeterminate state: False > > The only difference from the expected result is that, it doesn't show two messages: > [check box | All condiments] indeterminate state changed to: False > [check box | All condiments] indeterminate state changed to: True > > Those should be produced while changing state of "Lettuce" checkbox. > > Events are not propagated properly ? I think they might even not being generated, so that's why you don't get those. Which means that there are two bugs: one about the exposure of the state and other one related to exposing the state change. I think you can work on the first issue as part of this bug (and so I would only ask you to consider moving the test to LayoutTests/accessibility, updating the mac's TestExpectations file), and leave the other issue to be tackled as part of bug 123889. Created attachment 220218 [details]
patch
(In reply to comment #7) > Created an attachment (id=220218) [details] > patch Applied Mario's suggestions Comment on attachment 220218 [details]
patch
Thanks for the patch, Krzysztof. It looks good to me although I just realized you need to provide empty functions for the win and the ios ports too, and add the new test to win/TestExpectations.
Setting r+ now, but please consider those two things before landing.
Committed r161417: <http://trac.webkit.org/changeset/161417> (In reply to comment #9) > (From update of attachment 220218 [details]) > Thanks for the patch, Krzysztof. It looks good to me although I just realized you need to provide empty functions for the win and the ios ports too, and add the new test to win/TestExpectations. > > Setting r+ now, but please consider those two things before landing. Thanks Mario, applied suggestions. |