Bug 125855 – [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE

• Component: Accessibility
• Status: RESOLVED FIXED

[Krzysztof Czech]

Based on w3c, aria-checked mixed can be exposed as a ATK_STATE_INDETERMINATE for radio and checkbox types.

[Krzysztof Czech]

Created attachment 219412 [details]
patch

[Mario Sanchez Prada]

Comment on attachment 219412 [details]
patch

Thanks for the patch Krzysztof. Could you check if this patch of yours also fixes the issue reported in bug 123889 (see description and the event listener provided by Joanie there) and, if so, resolve one bug as a duplicate of the other?

Also, I think you'd better place the HTML and expected files for this one in LayoutTests/accessibility and add it to the TestExpectations file for the mac (with a comment saying that isIndeterminate() is not implemented there), so we avoid that much duplication.

Thanks!

[chris fleizach]

Comment on attachment 219412 [details]
patch

r- for Mario's comments (want to keep the review queue clear)

[Krzysztof Czech]

(In reply to comment #2)
> (From update of attachment 219412 [details])
> Thanks for the patch Krzysztof. Could you check if this patch of yours also fixes the issue reported in bug 123889 (see description and the event listener provided by Joanie there) and, if so, resolve one bug as a duplicate of the other?
> 
> Also, I think you'd better place the HTML and expected files for this one in LayoutTests/accessibility and add it to the TestExpectations file for the mac (with a comment saying that isIndeterminate() is not implemented there), so we avoid that much duplication.
> 
> Thanks!

I checked the issue reported in bug 123889. 
WebKitGtk MiniBrowser including my patch produces the fallowing results

[check box | All condiments] has indeterminate state: True
[check box | Lettuce] has indeterminate state: False

The only difference from the expected result is that, it doesn't show two messages:
[check box | All condiments] indeterminate state changed to: False
[check box | All condiments] indeterminate state changed to: True

Those should be produced while changing state of "Lettuce" checkbox.

Events are not propagated properly ?

[Mario Sanchez Prada]

(In reply to comment #4)
> [...] 
> I checked the issue reported in bug 123889. 
> WebKitGtk MiniBrowser including my patch produces the fallowing results
> 
> [check box | All condiments] has indeterminate state: True
> [check box | Lettuce] has indeterminate state: False
> 
> The only difference from the expected result is that, it doesn't show two messages:
> [check box | All condiments] indeterminate state changed to: False
> [check box | All condiments] indeterminate state changed to: True
> 
> Those should be produced while changing state of "Lettuce" checkbox.
> 
> Events are not propagated properly ?

I think they might even not being generated, so that's why you don't get those. Which means that there are two bugs: one about the exposure of the state and other one related to exposing the state change.

I think you can work on the first issue as part of this bug (and so I would only ask you to consider moving the test to LayoutTests/accessibility, updating the mac's TestExpectations file), and leave the other issue to be tackled as part of bug 123889.

[Radar WebKit Bug Importer]

<rdar://problem/15710141>

[Krzysztof Czech]

Created attachment 220218 [details]
patch

[Krzysztof Czech]

(In reply to comment #7)
> Created an attachment (id=220218) [details]
> patch
Applied Mario's suggestions

[Mario Sanchez Prada]

Comment on attachment 220218 [details]
patch

Thanks for the patch, Krzysztof. It looks good to me although I just realized you need to provide empty functions for the win and the ios ports too, and add the new test to win/TestExpectations.

Setting r+ now, but please consider those two things before landing.

[Krzysztof Czech]

Committed r161417: <http://trac.webkit.org/changeset/161417>

[Krzysztof Czech]

(In reply to comment #9)
> (From update of attachment 220218 [details])
> Thanks for the patch, Krzysztof. It looks good to me although I just realized you need to provide empty functions for the win and the ios ports too, and add the new test to win/TestExpectations.
> 
> Setting r+ now, but please consider those two things before landing.
Thanks Mario, applied suggestions.