Bug 125847

Summary: Should not have identifiers with underscores in them, especially not leading underscores.
Product: WebKit Reporter: Gergő Balogh <gbalogh.u-szeged>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Gergő Balogh
Reported 2013-12-17 02:21:31 PST
example: Options::Options(double _default_long_timeout, double _default_short_timeout) Should be defaultLongTimeout and defaultShortTimeout.
Attachments
patch (4.61 KB, patch)
2013-12-18 08:17 PST, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gergő Balogh
Comment 1 2013-12-17 02:22:32 PST
RFC: it is true or not?
Darin Adler
Comment 2 2013-12-17 07:49:41 PST
This is all covered in the coding style document <http://www.webkit.org/coding/coding-style.html>. It doesn’t list everything that it prohibits, but it’s clear that underscores are used only in macros (it calls them “defined constants”).
Alexey Proskuryakov
Comment 3 2013-12-17 11:50:28 PST
There are some exceptions where underscores are needed to match names coming from elsewhere (e.g. please don't rename CryptoAlgorithmRSAES_PKCS1_v1_5.h), but this example is clearly in violation of WebKit rules.
Gergő Balogh
Comment 4 2013-12-18 08:17:55 PST
Created attachment 219536 [details] patch This is fix the existing underscore checking logic, which ignored the constructor definitions.
WebKit Commit Bot
Comment 5 2013-12-18 10:03:44 PST
Comment on attachment 219536 [details] patch Clearing flags on attachment: 219536 Committed r160773: <http://trac.webkit.org/changeset/160773>
WebKit Commit Bot
Comment 6 2013-12-18 10:03:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.