Bug 125814

Summary:

Fix some whitespace issues in inspector code

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2013-12-16 16:27:10 PST

There were a bunch of ", " issues throughout the code. Fix the double space issue.

Attachments
[PATCH] Proposed Fix (10.59 KB, patch) 2013-12-16 16:28 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (10.55 KB, patch) 2013-12-16 16:40 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2013-12-16 16:28:10 PST

Created attachment 219367 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 2 2013-12-16 16:30:25 PST

Attachment 219367 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/inspector/protocol/Debugger.json', u'Source/JavaScriptCore/inspector/protocol/Runtime.json', u'Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/protocol/DOM.json', u'Source/WebCore/inspector/protocol/DOMStorage.json', u'Source/WebCore/inspector/protocol/Timeline.json', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 3 2013-12-16 16:40:25 PST

Created attachment 219368 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 4 2013-12-16 17:56:53 PST

Comment on attachment 219368 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219368 Committed r160683: <http://trac.webkit.org/changeset/160683>

WebKit Commit Bot

Comment 5 2013-12-16 17:56:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.