|
Description
Gavin Barraclough
2013-12-16 14:36:58 PST
Created attachment 219355 [details]
Fix
Comment on attachment 219355 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=219355&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3052 > + for (HashSet<PluginView*>::const_iterator it = m_pluginViews.begin(), end = m_pluginViews.end(); it != end; ++it) > + (*it)->setLayerHostingMode(layerHostingMode); This can be a range-based for loop. Comment on attachment 219355 [details] Fix Attachment 219355 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46338172 New failing tests: fast/css/box-shadow-viewport-vmin.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219377 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 219355 [details] Fix Attachment 219355 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/49118233 Created attachment 219432 [details]
Anders review fix + speculative gtk/efl fix.
Comment on attachment 219432 [details]
Anders review fix + speculative gtk/efl fix.
Ooops, didn't mean to set r? – this change r+'ed already by Anders.
Comment on attachment 219432 [details] Anders review fix + speculative gtk/efl fix. Attachment 219432 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/49928270 Created attachment 219438 [details]
Bah import.
Comment on attachment 219438 [details] Bah import. Attachment 219438 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/46658495 Comment on attachment 219438 [details] Bah import. Attachment 219438 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47628237 New failing tests: fast/css/box-shadow-viewport-vmin.html fast/regions/repaint/fixed-in-named-flow-cb-changed2.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html mathml/presentation/attributes-style.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html fast/regions/repaint/fixed-in-named-flow-cb-changed.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219444 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219447 [details]
Add missing PageClientImpl::isLayerWindowServerHosted() for gtk/ios
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 219447 [details] Add missing PageClientImpl::isLayerWindowServerHosted() for gtk/ios Attachment 219447 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/49598271 Created attachment 219461 [details]
More fixage
Comment on attachment 219461 [details] More fixage Attachment 219461 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/48008346 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html fast/css/box-shadow-viewport-vmin.html editing/unsupported-content/list-delete-003.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/list-delete-001.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html editing/unsupported-content/list-type-after.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html editing/unsupported-content/table-type-after.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219491 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 219461 [details] More fixage Attachment 219461 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/48388142 Created attachment 219495 [details]
Can't repro the mathml failures locally, giving the bot another try.
Comment on attachment 219495 [details] Can't repro the mathml failures locally, giving the bot another try. Attachment 219495 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/50378047 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html fast/css/box-shadow-viewport-vmin.html editing/unsupported-content/list-delete-003.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/list-delete-001.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html editing/unsupported-content/list-type-after.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html editing/unsupported-content/table-type-after.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219501 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219514 [details]
Fix
Created attachment 219516 [details]
D'oh
Comment on attachment 219516 [details] D'oh Attachment 219516 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/49938422 New failing tests: fast/css/box-shadow-viewport-vmin.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219531 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219542 [details]
Testing the trybot
Created attachment 219613 [details]
Testing partial patch - this will end up clearing the server hosted state until the view goes into a window.
Created attachment 219615 [details]
Another partial patch
Created attachment 219621 [details]
Another partial patch
Created attachment 219625 [details]
Another partial patch
Comment on attachment 219621 [details] Another partial patch Attachment 219621 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/50608019 Created attachment 219672 [details]
Another partial patch
Comment on attachment 219672 [details] Another partial patch Attachment 219672 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/50208066 New failing tests: fast/css/box-shadow-viewport-vmin.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219677 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219733 [details]
Again
Comment on attachment 219733 [details] Again Attachment 219733 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/44378236 New failing tests: fast/css/box-shadow-viewport-vmin.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219734 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219735 [details]
again
Created attachment 219767 [details]
again
Created attachment 219778 [details]
again
Comment on attachment 219767 [details] again Attachment 219767 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/48928083 New failing tests: editing/execCommand/format-block-multiple-paragraphs-in-pre.html Created attachment 219829 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 219778 [details] again Attachment 219778 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/49768046 New failing tests: fast/css/box-shadow-viewport-vmin.html fast/css/box-shadow-negative-viewportlength.html fast/css/box-shadow-viewport-height.html fast/css/border-radius-inset-box-shadow-viewportlength.html fast/css/box-shadow-viewport-width.html mathml/presentation/mfrac-linethickness3.html fast/css/drop-shadow-viewport-vmax.html fast/css/border-radius-viewport-vmin.html platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html fast/css/box-shadow-viewport-vmax.html fast/css/drop-shadow-viewport-height.html mathml/presentation/fractions-color.html platform/mac/fonts/han-disunification.html mathml/presentation/attributes-style.html fast/css/border-radius-viewport-height.html mathml/presentation/scripts-font-size.html mathml/presentation/style-color-sqrt.html fast/css/border-radius-viewport-vmax.html mathml/presentation/mfrac-linethickness1.html mathml/presentation/mo-stretchy-vertical-bar.html fast/css/drop-shadow-viewport-width.html fast/harness/sample-mismatch-reftest.html fast/css/drop-shadow-viewport-vmin.html Created attachment 219856 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219858 [details]
again
Attachment 219858 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/Shared/ViewState.h', u'Source/WebKit2/Shared/WebPageCreationParameters.cpp', u'Source/WebKit2/Shared/WebPageCreationParameters.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm', u'Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp', u'Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h', u'Source/WebKit2/UIProcess/DrawingAreaProxy.h', u'Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp', u'Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h', u'Source/WebKit2/UIProcess/PageClient.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2109: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 219860 [details]
again
Created attachment 219861 [details]
again
Created attachment 219863 [details]
again
Created attachment 219864 [details]
again
Created attachment 219865 [details]
Fixed?
Committed revision 160977. |