Bug 125791 – CStack Branch: Eliminate topOfStack parameter from callToJavaScript() and callToNativeFunction()

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Michael Saboff]

Since callToJavaScript() and callToNativeFunction() now use the C stack, the last Register* topOfStack parameter can be removed.

[Michael Saboff]

Created attachment 219335 [details]
Patch

[Mark Lam]

Comment on attachment 219335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219335&action=review

> Source/JavaScriptCore/llint/LLIntThunks.h:44
> +    EncodedJSValue callToJavaScript(void*, ExecState**, ProtoCallFrame*);
> +    EncodedJSValue callToNativeFunction(void*, ExecState**, ProtoCallFrame*);

The ExecState** argument doesn't agree with the VM* arg in LowLevelInterpreter.asm below.  Which is it supposed to be?

[Geoffrey Garen]

Comment on attachment 219335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219335&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:468
> +# EncodedJSValue callToJavaScript(void* code, VM* vm, ProtoCallFrame* protoFrame)
> +# EncodedJSValue callToNativeFunction(void* code, VM* vm, ProtoCallFrame* protoFrame)

Please change this from VM* to ExecState**. As Mark pointed out, this doesn't match our declaration. Callers pass &vm.topCallFrame, which is an ExecState**.

[Michael Saboff]

Committed r160660: <http://trac.webkit.org/changeset/160660>