Summary: | [CSS Regions][CSS Shapes] ASSERTION FAILED: m_segmentRanges.size() < m_segments.size() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||||
Component: | CSS | Assignee: | Zoltan Horvath <zoltan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 89256 | ||||||||||
Attachments: |
|
Description
Zoltan Horvath
2013-12-16 01:35:40 PST
Created attachment 219304 [details]
Patch
Comment on attachment 219304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219304&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1231 > + RenderRegion* regionAtNewLogicalHeight = regionAtBlockOffset(logicalHeight()); > + if (!currentRegion->isLastRegion() && currentRegion != regionAtNewLogicalHeight) { > + currentRegion = regionAtNewLogicalHeight; > + shapeInsideInfo = currentRegion->shapeInsideInfo(); > + } What if regionAtBlockOffset returns nullptr? Created attachment 219345 [details] Patch - address Darin's comment > What if regionAtBlockOffset returns nullptr? It should never happen at this point. I added an ASSERT for checking it. Comment on attachment 219345 [details] Patch - address Darin's comment View in context: https://bugs.webkit.org/attachment.cgi?id=219345&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1226 > + // flows into the next region with a shape, we need to update the current shape and region This code seems like it belongs in the "overflowsToNextRegion" case above, as it is very strange to have two different places in the same function that move to the next region, and it also makes the code hard to follow. If it doesn't make the patch too big, I would prefer if this is refactored to make that possible. If not, then a FIXME comment here is ok, with a reference to a bug to do the refactor. Created attachment 220463 [details]
Patch
Comment on attachment 220463 [details]
Patch
That looks a lot better!
Comment on attachment 220463 [details] Patch Clearing flags on attachment: 220463 Committed r161384: <http://trac.webkit.org/changeset/161384> All reviewed patches have been landed. Closing bug. |