Bug 125753

Summary: win64 build broken
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, kondapallykalyan, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2013-12-14 20:51:31 PST 
The 64-bit build was forgotten in the update to VS2013.  I've cleaned it up a bit.

The 64-bit configurations and QTMovieWin needed the updated platform toolset, JavaScriptCore shouldn't assemble JITStubsMSVC64.asm until it's ready to be used (it causes linker errors right now), and WebInspectorUI.vcxproj needs a 64-bit configuration.
Comment 1 Alex Christensen 2013-12-14 21:06:40 PST 
Created attachment 219269 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-14 21:07:28 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Brent Fulgham 2013-12-15 18:39:54 PST 
Comment on attachment 219269 [details]
Patch

We should be using v120 for 64-bit, as there is no need to retain Windows XP compatibility for the 64-bit platform.

Also, the QTMovieWin project is being deprecated, so please don't include changes to that project.
Comment 4 Alex Christensen 2013-12-16 08:18:25 PST 
(In reply to comment #3)
> (From update of attachment 219269 [details])
> We should be using v120 for 64-bit, as there is no need to retain Windows XP compatibility for the 64-bit platform.
I disagree.  There is a 64-bit Windows XP, and I would like to support it as long as there is an XP compatible toolset, unless there is a compelling reason to not use it.
> 
> Also, the QTMovieWin project is being deprecated, so please don't include changes to that project.
Great!  I'll remove those changes.
Comment 5 Alex Christensen 2013-12-16 08:25:22 PST 
Created attachment 219321 [details]
Patch
Comment 6 Alex Christensen 2013-12-16 11:08:42 PST 
Created attachment 219334 [details]
Patch
Comment 7 Alex Christensen 2013-12-16 11:11:15 PST 
I went through it and made Debug_WinCairo and Release_WinCairo have v120_xp.  Debug|x64, DebugSuffix|x64, Production|x64, and Release|x64 have v120.  The diff does not make this obvious.  Good luck reviewing this.
Comment 8 Brent Fulgham 2013-12-16 12:12:24 PST 
Comment on attachment 219334 [details]
Patch

r=me.
Comment 9 WebKit Commit Bot 2013-12-16 12:40:49 PST 
Comment on attachment 219334 [details]
Patch

Clearing flags on attachment: 219334

Committed r160655: <http://trac.webkit.org/changeset/160655>
Comment 10 WebKit Commit Bot 2013-12-16 12:40:52 PST 
All reviewed patches have been landed.  Closing bug.