Bug 125753

Summary:

win64 build broken

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, dino, kondapallykalyan, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 8

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2013-12-14 20:51:31 PST

The 64-bit build was forgotten in the update to VS2013. I've cleaned it up a bit. The 64-bit configurations and QTMovieWin needed the updated platform toolset, JavaScriptCore shouldn't assemble JITStubsMSVC64.asm until it's ready to be used (it causes linker errors right now), and WebInspectorUI.vcxproj needs a 64-bit configuration.

Attachments
Patch (83.81 KB, patch) 2013-12-14 21:06 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (80.49 KB, patch) 2013-12-16 08:25 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (98.65 KB, patch) 2013-12-16 11:08 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-12-14 21:06:40 PST

Created attachment 219269 [details] Patch

WebKit Commit Bot

Comment 2 2013-12-14 21:07:28 PST

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Brent Fulgham

Comment 3 2013-12-15 18:39:54 PST

Comment on attachment 219269 [details] Patch We should be using v120 for 64-bit, as there is no need to retain Windows XP compatibility for the 64-bit platform. Also, the QTMovieWin project is being deprecated, so please don't include changes to that project.

Alex Christensen

Comment 4 2013-12-16 08:18:25 PST

(In reply to comment #3) > (From update of attachment 219269 [details]) > We should be using v120 for 64-bit, as there is no need to retain Windows XP compatibility for the 64-bit platform. I disagree. There is a 64-bit Windows XP, and I would like to support it as long as there is an XP compatible toolset, unless there is a compelling reason to not use it. > > Also, the QTMovieWin project is being deprecated, so please don't include changes to that project. Great! I'll remove those changes.

Alex Christensen

Comment 5 2013-12-16 08:25:22 PST

Created attachment 219321 [details] Patch

Alex Christensen

Comment 6 2013-12-16 11:08:42 PST

Created attachment 219334 [details] Patch

Alex Christensen

Comment 7 2013-12-16 11:11:15 PST

I went through it and made Debug_WinCairo and Release_WinCairo have v120_xp. Debug|x64, DebugSuffix|x64, Production|x64, and Release|x64 have v120. The diff does not make this obvious. Good luck reviewing this.

Brent Fulgham

Comment 8 2013-12-16 12:12:24 PST

Comment on attachment 219334 [details] Patch r=me.

WebKit Commit Bot

Comment 9 2013-12-16 12:40:49 PST

Comment on attachment 219334 [details] Patch Clearing flags on attachment: 219334 Committed r160655: <http://trac.webkit.org/changeset/160655>

WebKit Commit Bot

Comment 10 2013-12-16 12:40:52 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.