Bug 12575

Summary: SVG Links do not show status text on hover
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.w3.org/Graphics/SVG/Test/20061213/htmlEmbedHarness/full-linking-a-04-t.html
Attachments:
Description Flags
The fix (and test case)
none
even cleaner patch (and test case) darin: review+

Description Eric Seidel (no email) 2007-02-04 03:43:41 PST
SVG Links do not show status text on hover

The referenced URL is one of many examples where this fails.
Comment 1 Eric Seidel (no email) 2007-02-04 05:28:40 PST
Created attachment 12914 [details]
The fix (and test case)

It's a little ugly to add all of these SVG_SUPPORTs into this base code, but it's following the existing practice from HTML (which special cases various HTML elements).
Comment 2 Eric Seidel (no email) 2007-02-04 05:56:33 PST
Created attachment 12915 [details]
even cleaner patch (and test case)
Comment 3 Darin Adler 2007-02-04 18:53:04 PST
Comment on attachment 12915 [details]
even cleaner patch (and test case)

+#ifdef SVG_SUPPORT
+    else if (m_innerURLElement->hasTagName(SVGNames::aTag))
+        return m_innerURLElement->isLink();
+#endif

No need for else here. The if before ends in a return.

Would be nice if this had a layout test. We could easily add logging of the delegate methods used for status text.

r=me
Comment 4 Eric Seidel (no email) 2007-02-05 03:31:06 PST
r19400.

Status text is only part of what changed here.  I coped out and didn't add the DRT functionality or test.