Bug 125742

Summary: [iOS] Upstream changes to FeatureDefines.xcconfig
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[iOS] Upstream changes to FeatureDefines.xcconfig mitz: review+

Andy Estes
Reported 2013-12-14 16:21:03 PST
[iOS] Upstream changes to FeatureDefines.xcconfig
Attachments
[iOS] Upstream changes to FeatureDefines.xcconfig (49.01 KB, patch)
2013-12-14 16:22 PST, Andy Estes 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-12-14 16:22:29 PST
Created attachment 219260 [details] [iOS] Upstream changes to FeatureDefines.xcconfig
Joseph Pecoraro
Comment 2 2013-12-15 01:14:35 PST
Comment on attachment 219260 [details] [iOS] Upstream changes to FeatureDefines.xcconfig Does this make the FeatureDefines.xcconfig files identical across all projects? They should be, but they frequently get out of sync. It would be nice to sync them up!
Andy Estes
Comment 3 2013-12-15 01:19:12 PST
(In reply to comment #2) > (From update of attachment 219260 [details]) > Does this make the FeatureDefines.xcconfig files identical across all projects? They should be, but they frequently get out of sync. It would be nice to sync them up! https://bugs.webkit.org/show_bug.cgi?id=125741 got them in sync, and this updated them all identically.
Andy Estes
Comment 4 2013-12-15 01:20:37 PST
See also thorton's patch teaching stylebot to warn about out-of-sync FeatureDefines: https://bugs.webkit.org/show_bug.cgi?id=125748
Andy Estes
Comment 5 2013-12-15 13:05:52 PST
Committed r160621: <http://trac.webkit.org/changeset/160621>
Note You need to log in before you can comment on or make changes to this bug.