Bug 125742

Summary: [iOS] Upstream changes to FeatureDefines.xcconfig
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[iOS] Upstream changes to FeatureDefines.xcconfig mitz: review+

Description Andy Estes 2013-12-14 16:21:03 PST
[iOS] Upstream changes to FeatureDefines.xcconfig
Comment 1 Andy Estes 2013-12-14 16:22:29 PST
Created attachment 219260 [details]
[iOS] Upstream changes to FeatureDefines.xcconfig
Comment 2 Joseph Pecoraro 2013-12-15 01:14:35 PST
Comment on attachment 219260 [details]
[iOS] Upstream changes to FeatureDefines.xcconfig

Does this make the FeatureDefines.xcconfig files identical across all projects? They should be, but they frequently get out of sync. It would be nice to sync them up!
Comment 3 Andy Estes 2013-12-15 01:19:12 PST
(In reply to comment #2)
> (From update of attachment 219260 [details])
> Does this make the FeatureDefines.xcconfig files identical across all projects? They should be, but they frequently get out of sync. It would be nice to sync them up!

https://bugs.webkit.org/show_bug.cgi?id=125741 got them in sync, and this updated them all identically.
Comment 4 Andy Estes 2013-12-15 01:20:37 PST
See also thorton's patch teaching stylebot to warn about out-of-sync FeatureDefines: https://bugs.webkit.org/show_bug.cgi?id=125748
Comment 5 Andy Estes 2013-12-15 13:05:52 PST
Committed r160621: <http://trac.webkit.org/changeset/160621>