Bug 125732

Summary: Some Set and Map prototype functions have incorrect function lengths
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-12-13 21:42:55 PST
Caught while reading through SetPrototype.cpp. Looks like a few of the prototype functions have an unexpected function length. `add` should be 1 since it takes a param, `clear` should be 0 since it doesn't take a param.
Attachments
[PATCH] Proposed Fix (2.63 KB, patch)
2013-12-13 21:43 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (7.12 KB, patch)
2013-12-13 22:02 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-12-13 21:43:57 PST
Created attachment 219235 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2013-12-13 21:51:08 PST
Looking through JSC_NATIVE_FUNCTION calls, these are suspect as well: runtime/MapPrototype.cpp 67: JSC_NATIVE_FUNCTION(vm.propertyNames->keys, mapProtoFuncKeys, DontEnum, 2); 68: JSC_NATIVE_FUNCTION(vm.propertyNames->values, mapProtoFuncValues, DontEnum, 2); 69: JSC_NATIVE_FUNCTION(vm.propertyNames->entries, mapProtoFuncEntries, DontEnum, 2); 70: JSC_NATIVE_FUNCTION(vm.propertyNames->iteratorPrivateName, mapProtoFuncEntries, DontEnum, 2); Should probably all be 0, eh? I'll address these as well.
Joseph Pecoraro
Comment 3 2013-12-13 22:02:27 PST
Created attachment 219236 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 4 2013-12-13 23:50:36 PST
Comment on attachment 219236 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219236 Committed r160592: <http://trac.webkit.org/changeset/160592>
WebKit Commit Bot
Comment 5 2013-12-13 23:50:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.