Bug 125717

Summary:

Fix QuickTime plug-in replacement scripting bugs

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebCore Misc.

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, jer.noble, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Updated patch	none

Eric Carlson

Reported 2013-12-13 16:39:12 PST

The QuickTime plug-in replacement added in 124900 doesn't support the 'qtsrc' attribute, and it doesn't resolve urls passed to the SetURL method correctly. URLs are assumed to be relative to the original 'src' attribute because when it first shipped (for Netscape 3.x), it was not possible for a plug-in to get the url of the page in which it was embedded.

Attachments
Proposed patch (9.62 KB, patch) 2013-12-13 18:01 PST, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (496.73 KB, application/zip) 2013-12-13 19:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (557.33 KB, application/zip) 2013-12-13 20:02 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (457.62 KB, application/zip) 2013-12-13 20:02 PST, Build Bot	no flags	Details
Updated patch (80.81 KB, patch) 2013-12-13 22:42 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2013-12-13 18:01:45 PST

Created attachment 219214 [details] Proposed patch

Build Bot

Comment 2 2013-12-13 19:35:55 PST

Comment on attachment 219214 [details] Proposed patch Attachment 219214 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/49108010 New failing tests: plugins/quicktime-plugin-replacement.html

Build Bot

Comment 3 2013-12-13 19:35:56 PST

Created attachment 219221 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2013-12-13 20:02:18 PST

Comment on attachment 219214 [details] Proposed patch Attachment 219214 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47548049 New failing tests: plugins/quicktime-plugin-replacement.html

Build Bot

Comment 5 2013-12-13 20:02:21 PST

Created attachment 219224 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2013-12-13 20:02:38 PST

Comment on attachment 219214 [details] Proposed patch Attachment 219214 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/49038024 New failing tests: plugins/quicktime-plugin-replacement.html

Build Bot

Comment 7 2013-12-13 20:02:40 PST

Created attachment 219225 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Eric Carlson

Comment 8 2013-12-13 22:42:51 PST

Created attachment 219240 [details] Updated patch Add missing video file.

WebKit Commit Bot

Comment 9 2013-12-16 08:01:39 PST

Comment on attachment 219240 [details] Updated patch Clearing flags on attachment: 219240 Committed r160640: <http://trac.webkit.org/changeset/160640>

WebKit Commit Bot

Comment 10 2013-12-16 08:01:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.