Bug 125710

Summary: [GTK] Remove Warnings in building about duplicate INSPECTOR variables
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, gustavo, joepeck, mrobinson, timothy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix thorton: review+

Joseph Pecoraro
Reported 2013-12-13 13:41:12 PST
GNUmakefile builds are warning about duplicate definitions of INSPECTOR_SCRIPTS and INSPECTOR_DOMAINS. Clean that up so there are no warnings.
Attachments
[PATCH] Proposed Fix (4.36 KB, patch)
2013-12-13 13:42 PST, Joseph Pecoraro 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-12-13 13:42:36 PST
Created attachment 219193 [details] [PATCH] Proposed Fix The EWS bots I think filter the output, which will make it hard to know if this cleans up the warnings or not.
Joseph Pecoraro
Comment 2 2013-12-13 13:43:55 PST
Warnings I'm attempting to resolve: > Source/WebCore/GNUmakefile.am:336: warning: INSPECTOR_SCRIPTS_DIR multiply defined in condition TRUE ... > GNUmakefile.am:201: 'Source/WebCore/GNUmakefile.am' included from here > Source/JavaScriptCore/GNUmakefile.am:222: ... 'INSPECTOR_SCRIPTS_DIR' previously defined here > GNUmakefile.am:199: 'Source/JavaScriptCore/GNUmakefile.am' included from here > Source/WebCore/GNUmakefile.am:338: warning: INSPECTOR_DOMAINS multiply defined in condition TRUE ... > GNUmakefile.am:201: 'Source/WebCore/GNUmakefile.am' included from here > Source/JavaScriptCore/GNUmakefile.am:224: ... 'INSPECTOR_DOMAINS' previously defined here > GNUmakefile.am:199: 'Source/JavaScriptCore/GNUmakefile.am' included from here Seen on the build.webkit.org bots: <http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/39390/steps/compile-webkit/logs/stdio>
Martin Robinson
Comment 3 2014-03-25 15:36:05 PDT
The autotools build is gone now.
Note You need to log in before you can comment on or make changes to this bug.