Summary: | mandreel throws a checksum error on 32-bit x86 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Hahnenberg
2013-12-13 13:14:36 PST
The issue is due to the 32-bit DFG emitting code that load constants from its CodeBlock's m_constantRegisters vector, and then resizing that vector thereby rendering the addresses in the emitted code state. The fix is to use a dedicated doubles constant pool for the DFG stored in the DFG CommonData. Created attachment 228094 [details]
the patch.
Thanks. Landed in r166440: <http://trac.webkit.org/r166440>. |