Bug 125704

Summary: UInt32ToNumber should have an Int52 path
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenberg, msaboff, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Filip Pizlo
Reported 2013-12-13 13:01:57 PST
Patch forthcoming.
Attachments
Patch (5.51 KB, patch)
2016-04-08 01:58 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (7.45 KB, patch)
2016-04-08 02:02 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-04-08 01:58:30 PDT
Created attachment 275985 [details] Patch
Benjamin Poulain
Comment 2 2016-04-08 02:00:48 PDT
Neutral...but we don't really have coverage of unsigned with ASM.js. Conf#1 Conf#2 SunSpider: 3d-cube 5.0398+-0.0853 ? 5.2331+-0.1937 ? might be 1.0384x slower 3d-morph 5.2203+-0.0881 ? 5.2363+-0.1236 ? 3d-raytrace 5.5372+-0.0485 ? 5.5673+-0.1024 ? access-binary-trees 2.1020+-0.0425 ? 2.1132+-0.0240 ? access-fannkuch 5.8211+-0.1565 ? 6.0523+-0.1606 ? might be 1.0397x slower access-nbody 2.5650+-0.0395 ? 2.6356+-0.0906 ? might be 1.0275x slower access-nsieve 3.1195+-0.1069 3.1097+-0.1112 bitops-3bit-bits-in-byte 1.2264+-0.1910 1.1183+-0.0117 might be 1.0967x faster bitops-bits-in-byte 2.8386+-0.1001 2.8110+-0.0440 bitops-bitwise-and 2.0770+-0.0466 2.0703+-0.0430 bitops-nsieve-bits 3.1347+-0.0594 3.1024+-0.0334 might be 1.0104x faster controlflow-recursive 2.4216+-0.0644 2.3548+-0.0179 might be 1.0284x faster crypto-aes 3.9739+-0.0442 3.9571+-0.0217 crypto-md5 2.4937+-0.0743 ? 2.4945+-0.0500 ? crypto-sha1 2.4166+-0.1056 2.3822+-0.0448 might be 1.0144x faster date-format-tofte 6.3752+-0.1836 ? 6.5273+-0.3012 ? might be 1.0239x slower date-format-xparb 4.8274+-0.1945 4.6716+-0.0572 might be 1.0333x faster math-cordic 2.8879+-0.0318 ? 2.9421+-0.0743 ? might be 1.0188x slower math-partial-sums 4.9552+-0.1767 4.8119+-0.1083 might be 1.0298x faster math-spectral-norm 2.0047+-0.0393 1.9810+-0.0150 might be 1.0120x faster regexp-dna 6.3292+-0.1409 ? 6.4438+-0.2396 ? might be 1.0181x slower string-base64 4.4503+-0.0622 4.4142+-0.0599 string-fasta 5.7780+-0.0605 5.7738+-0.0345 string-tagcloud 8.2861+-0.1922 8.1985+-0.1447 might be 1.0107x faster string-unpack-code 19.5598+-0.5401 ? 19.7490+-0.5318 ? string-validate-input 4.3089+-0.0703 ? 4.3731+-0.1414 ? might be 1.0149x slower <arithmetic> 4.6058+-0.0287 ? 4.6202+-0.0296 ? might be 1.0031x slower Conf#1 Conf#2 Octane: encrypt 0.16431+-0.00117 0.16425+-0.00086 decrypt 2.83950+-0.00409 ? 2.85146+-0.00950 ? deltablue x2 0.13901+-0.00107 ? 0.13903+-0.00162 ? earley 0.28678+-0.00132 0.28579+-0.00109 boyer 5.05824+-0.01189 5.05701+-0.00668 navier-stokes x2 4.99127+-0.00651 ? 4.99667+-0.01199 ? raytrace x2 0.79830+-0.00308 0.79818+-0.00355 richards x2 0.08350+-0.00056 ? 0.08371+-0.00072 ? splay x2 0.34286+-0.00163 0.34111+-0.00181 regexp x2 15.84318+-0.18109 15.79329+-0.14547 pdfjs x2 38.63328+-0.17749 38.60572+-0.24659 mandreel x2 42.58114+-0.12890 ? 42.71172+-0.28116 ? gbemu x2 24.09101+-0.21864 ? 24.14812+-0.13786 ? closure 0.52789+-0.00118 0.52642+-0.00174 jquery 6.81988+-0.01533 ? 6.84799+-0.02072 ? box2d x2 9.20683+-0.03968 9.15287+-0.02440 zlib x2 359.01078+-3.72784 355.60043+-4.36117 typescript x2 632.28019+-1.94535 629.15925+-2.28924 <geometric> 5.02056+-0.00562 5.01395+-0.00825 might be 1.0013x faster Conf#1 Conf#2 Kraken: ai-astar 88.588+-0.867 ? 88.781+-1.160 ? audio-beat-detection 42.101+-0.240 ? 42.421+-0.393 ? audio-dft 100.074+-1.291 99.372+-0.880 audio-fft 32.772+-0.084 ? 32.983+-0.309 ? audio-oscillator 48.385+-0.618 47.969+-0.372 imaging-darkroom 60.157+-0.036 ? 60.755+-1.019 ? imaging-desaturate 45.279+-0.180 ? 45.449+-0.336 ? imaging-gaussian-blur 61.186+-1.310 ? 62.595+-0.556 ? might be 1.0230x slower json-parse-financial 37.900+-0.395 37.767+-0.179 json-stringify-tinderbox 24.221+-0.777 ? 24.369+-0.500 ? stanford-crypto-aes 39.150+-0.105 39.114+-0.163 stanford-crypto-ccm 33.602+-1.129 32.678+-1.242 might be 1.0283x faster stanford-crypto-pbkdf2 97.627+-0.486 97.520+-0.380 stanford-crypto-sha256-iterative 36.748+-0.062 36.740+-0.073 <arithmetic> 53.414+-0.222 ? 53.465+-0.140 ? might be 1.0010x slower Conf#1 Conf#2 AsmBench: bigfib.cpp 442.2818+-1.1866 ? 442.9089+-1.8647 ? cray.c 354.7595+-1.0519 ? 354.9053+-0.9481 ? dry.c 444.2202+-26.7712 ? 451.2143+-28.1737 ? might be 1.0157x slower FloatMM.c 727.6443+-3.5599 ? 728.1292+-4.1959 ? gcc-loops.cpp 3710.2041+-4.7124 ? 3726.3411+-17.9005 ? n-body.c 808.9163+-2.5508 807.7940+-1.4961 Quicksort.c 396.3946+-2.0744 ? 397.2640+-1.7607 ? stepanov_container.cpp 3305.2563+-15.1576 ? 3308.8421+-12.7612 ? Towers.c 272.1929+-0.7936 ? 273.3359+-1.6526 ? <geometric> 723.1137+-4.5991 ? 725.3627+-4.5310 ? might be 1.0031x slower Conf#1 Conf#2 Geomean of preferred means: <scaled-result> 30.7410+-0.0826 ? 30.7862+-0.0800 ? might be 1.0015x slower
Benjamin Poulain
Comment 3 2016-04-08 02:02:25 PDT
Created attachment 275986 [details] Patch
WebKit Commit Bot
Comment 4 2016-04-08 11:07:26 PDT
Comment on attachment 275986 [details] Patch Clearing flags on attachment: 275986 Committed r199235: <http://trac.webkit.org/changeset/199235>
WebKit Commit Bot
Comment 5 2016-04-08 11:07:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.