Bug 12567

Summary: <text> elements ignore <a> children
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: oliver
Priority: P2 Keywords: SVGHitList
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.w3.org/Graphics/SVG/Test/20061213/htmlEmbedHarness/full-interact-cursor-01-f.html
Bug Depends on:    
Bug Blocks: 12500    
Attachments:
Description Flags
test case
none
partial fix
none
First attempt
none
Improved patch zimmermann: review+

Eric Seidel (no email)
Reported 2007-02-04 03:17:07 PST
<text> elements ignore <a> children See attached test case.
Attachments
test case (88 bytes, image/svg+xml)
2007-02-04 03:17 PST, Eric Seidel (no email) 		no flags
Details
partial fix (4.96 KB, patch)
2007-02-05 06:19 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
First attempt (85.72 KB, patch)
2007-03-09 13:57 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Improved patch (85.74 KB, patch)
2007-03-10 04:28 PST, Rob Buis 		zimmermann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-02-04 03:17:56 PST
Created attachment 12912 [details] test case Firefox fails this test as well. Opera passes.
Eric Seidel (no email)
Comment 2 2007-02-04 03:59:35 PST
This also causes this test to fail: http://www.w3.org/Graphics/SVG/Test/20061213/htmlEmbedHarness/full-struct-frag-05-t.html
Eric Seidel (no email)
Comment 3 2007-02-05 06:19:16 PST
Created attachment 12933 [details] partial fix This "fixes" the bug, but crashes, due to RenderSVGInlineText not expecting an element other than a TextPositioningElement. I'm not sure if RenderSVGInline is the correct renderer for <a> to be making or not. We'd need to hear olliej's opinion on this. This also cleans up renderer creation, to prevent text renderers from being allowed in the wrong places.
Eric Seidel (no email)
Comment 4 2007-02-06 07:48:45 PST
This blocks at least 3-4 w3c tests, and is likely seen often "in the wild". Adding to the SVG hit list.
Rob Buis
Comment 5 2007-03-09 13:57:30 PST
Created attachment 13567 [details] First attempt Based on Eric's patch, this also fixes the SVGInlineFlowBox routines and starts supporting xlink:show. Cheers, Rob.
Rob Buis
Comment 6 2007-03-10 04:28:23 PST
Created attachment 13575 [details] Improved patch I got the target attribute down in my previous patch. I checked with Opera and it seems if either target="_self" or xlink:show="new" the link opens up in a new window, so I implemented it like this in this patch. Cheers, Rob.
Nikolas Zimmermann
Comment 7 2007-03-11 16:25:18 PDT
Comment on attachment 13575 [details] Improved patch Good patch! You mentioned that we now match Opera's behaviour - I guess FF/Batik handle it the same way? I do think the way you implemented it and how Opera handles it makes sense though, so r=me in any way :-) Niko
Rob Buis
Comment 8 2007-03-12 13:31:59 PDT
Landed in r20122.
Note You need to log in before you can comment on or make changes to this bug.